Bug 172686 - [JSC][Linux][FreeBSD] Use faster Interpreter::getOpcodeID()
Summary: [JSC][Linux][FreeBSD] Use faster Interpreter::getOpcodeID()
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Yusuke Suzuki
URL:
Keywords: InRadar
Depends on: 172669
Blocks:
  Show dependency tree / graph
 
Reported: 2017-05-28 04:40 PDT by Yusuke Suzuki
Modified: 2017-05-30 20:19 PDT (History)
11 users (show)

See Also:

Attachments
Patch (1.76 KB, patch)
2017-05-28 04:44 PDT, Yusuke Suzuki 		mark.lam: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Yusuke Suzuki 2017-05-28 04:40:06 PDT 
[JSC][Linux][FreeBSD] Use faster Interpreter::getOpcodeID()
Comment 1 Yusuke Suzuki 2017-05-28 04:44:10 PDT 
Created attachment 311435 [details]
Patch
Comment 2 Mark Lam 2017-05-28 05:59:56 PDT 
Comment on attachment 311435 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=311435&action=review

r=me

> Source/WTF/wtf/Platform.h:920
> +    (CPU(X86) || CPU(X86_64) || CPU(ARM64) || CPU(ARM_THUMB2)) && (OS(DARWIN) || OS(LINUX) || OS(FREEBSD))

Should this be enabled for all Unix OSes?  If so, we can just drop the OS(DARWIN) instead.  We already filter out MSVC above.  What do you think?
Comment 3 Yusuke Suzuki 2017-05-28 06:13:09 PDT 
Comment on attachment 311435 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=311435&action=review

>> Source/WTF/wtf/Platform.h:920
>> +    (CPU(X86) || CPU(X86_64) || CPU(ARM64) || CPU(ARM_THUMB2)) && (OS(DARWIN) || OS(LINUX) || OS(FREEBSD))
> 
> Should this be enabled for all Unix OSes?  If so, we can just drop the OS(DARWIN) instead.  We already filter out MSVC above.  What do you think?

I think it is reasonable. Let's do that ;)
Comment 4 Yusuke Suzuki 2017-05-28 07:12:03 PDT 
Committed r217528: <http://trac.webkit.org/changeset/217528>
Comment 5 Yusuke Suzuki 2017-05-28 10:37:29 PDT 
Linux ARM Thumb2 crashes. I'll check it tomorrow.
Comment 6 Yusuke Suzuki 2017-05-29 03:38:03 PDT 
Committed r217535: <http://trac.webkit.org/changeset/217535>
Comment 7 Radar WebKit Bug Importer 2017-05-30 20:19:49 PDT 
<rdar://problem/32479658>