Bug 172684 – [WebIDL] @@iterator should only be accessed once when disambiguating a union type

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Sam Weinig]

[WebIDL] @@iterator should only be accessed once when disambiguating a union type

[Sam Weinig]

Created attachment 311425 [details]
Patch

[Build Bot]

Comment on attachment 311425 [details]
Patch

Attachment 311425 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/3829266

New failing tests:
webrtc/peer-connection-audio-mute.html
fast/css/target-fragment-match.html

[Build Bot]

Created attachment 311427 [details]
Archive of layout-test-results from ews126 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews126  Port: ios-simulator-wk2  Platform: Mac OS X 10.12.5

[Sam Weinig]

I'm not convinced this patch did that. Seems very unlikely and for it to be iOS only is also suspect.

[Sam Weinig]

Created attachment 311429 [details]
Patch

[Sam Weinig]

I should note, this same issue exists for overload disambiguation, and that should eventually be fixed, but I don't know of any overloaded operations that take a sequence as an argument, so it's not observable at present.

[Yusuke Suzuki]

Comment on attachment 311429 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=311429&action=review

r=me

> Source/WebCore/ChangeLog:12
> +        the sequence conversion code re-accessed it, which is observable and wrong.

Yeah. It reminds me of the implementation of Array.from.

[WebKit Commit Bot]

Comment on attachment 311429 [details]
Patch

Clearing flags on attachment: 311429

Committed r217529: <http://trac.webkit.org/changeset/217529>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/32479661>