Bug 172664 - JSContext Inspector: Improve the reliability of automatically pausing in auto-attach
Summary: JSContext Inspector: Improve the reliability of automatically pausing in auto...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Joseph Pecoraro
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-05-26 14:32 PDT by Joseph Pecoraro
Modified: 2017-05-26 15:57 PDT (History)
10 users (show)

See Also:


Attachments
[PATCH] Proposed Fix (19.91 KB, patch)
2017-05-26 14:44 PDT, Joseph Pecoraro
no flags Details | Formatted Diff | Diff
[PATCH] Proposed Fix (20.29 KB, patch)
2017-05-26 14:47 PDT, Joseph Pecoraro
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Joseph Pecoraro 2017-05-26 14:32:48 PDT
Summary:
Improve the reliability of automatically pausing in auto-attach

Currently when autopause is enabled we trigger a pause, then open the frontend. It is often the case that the frontend perform actions in its initialization that cause us to unpause.

Lets defer the autopause pause to after the frontend has initialized. This is after all of the frontend's work and before any user scripts.
Comment 1 Joseph Pecoraro 2017-05-26 14:33:01 PDT
<rdar://problem/32362933>
Comment 2 Joseph Pecoraro 2017-05-26 14:44:45 PDT
Created attachment 311379 [details]
[PATCH] Proposed Fix
Comment 3 Joseph Pecoraro 2017-05-26 14:47:48 PDT
Created attachment 311380 [details]
[PATCH] Proposed Fix

Improved ChangeLog to describe the problem we are solving and why.
Comment 4 Matt Baker 2017-05-26 14:53:13 PDT
Comment on attachment 311380 [details]
[PATCH] Proposed Fix

r=me
Comment 5 WebKit Commit Bot 2017-05-26 15:57:01 PDT
Comment on attachment 311380 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 311380

Committed r217509: <http://trac.webkit.org/changeset/217509>
Comment 6 WebKit Commit Bot 2017-05-26 15:57:03 PDT
All reviewed patches have been landed.  Closing bug.