Bug 172663 – Web Inspector: Existing query in Search tab doesn't perform search on reload

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector

[Devin Rousso]

* STEPS TO REPRODUCE
1. Inspect <https://webkit.org>
2. Search for "div" via the search bar
3. The results are shown in the search tab
4. Cmd+R to reload the page

* EXPECTED
The search is re-performed on reload

* ACTUAL
No results for the search are shown

[Devin Rousso]

Created attachment 311392 [details]
Patch

[Devin Rousso]

Created attachment 311393 [details]
[Image] After Patch is applied

[Timothy Hatcher]

Comment on attachment 311392 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=311392&action=review

> Source/WebInspectorUI/UserInterface/Views/SearchSidebarPanel.js:418
> +            performSearchLink.textContent = WebInspector.UIString("Search Again");

Neat! I'd like this better if it was a rounded rect button, not a link.

[Devin Rousso]

Comment on attachment 311392 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=311392&action=review

>> Source/WebInspectorUI/UserInterface/Views/SearchSidebarPanel.js:418
>> +            performSearchLink.textContent = WebInspector.UIString("Search Again");
> 
> Neat! I'd like this better if it was a rounded rect button, not a link.

I was following the style of the Debugger sidebar, both when breakpoints are off and when a timeline is active.  Do you think it should be an "active" button (with the blue color)?  What were you thinking in terms of the button's style?

[Timothy Hatcher]

Comment on attachment 311392 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=311392&action=review

>>> Source/WebInspectorUI/UserInterface/Views/SearchSidebarPanel.js:418
>>> +            performSearchLink.textContent = WebInspector.UIString("Search Again");
>> 
>> Neat! I'd like this better if it was a rounded rect button, not a link.
> 
> I was following the style of the Debugger sidebar, both when breakpoints are off and when a timeline is active.  Do you think it should be an "active" button (with the blue color)?  What were you thinking in terms of the button's style?

If we have other cases of this style, then that is fine.

[WebKit Commit Bot]

Comment on attachment 311392 [details]
Patch

Clearing flags on attachment: 311392

Committed r217733: <http://trac.webkit.org/changeset/217733>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.