Bug 172663 - Web Inspector: Existing query in Search tab doesn't perform search on reload
Summary: Web Inspector: Existing query in Search tab doesn't perform search on reload
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Devin Rousso
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-05-26 13:40 PDT by Devin Rousso
Modified: 2017-06-02 13:57 PDT (History)
3 users (show)

See Also:

Attachments
Patch (7.04 KB, patch)
2017-05-26 16:08 PDT, Devin Rousso 		no flags Details | Formatted Diff | Diff
[Image] After Patch is applied (297.67 KB, image/png)
2017-05-26 16:08 PDT, Devin Rousso 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Devin Rousso 2017-05-26 13:40:20 PDT 
* STEPS TO REPRODUCE
1. Inspect <https://webkit.org>
2. Search for "div" via the search bar
3. The results are shown in the search tab
4. Cmd+R to reload the page

* EXPECTED
The search is re-performed on reload

* ACTUAL
No results for the search are shown
Comment 1 Devin Rousso 2017-05-26 16:08:37 PDT 
Created attachment 311392 [details]
Patch
Comment 2 Devin Rousso 2017-05-26 16:08:46 PDT 
Created attachment 311393 [details]
[Image] After Patch is applied
Comment 3 Timothy Hatcher 2017-06-02 10:06:02 PDT 
Comment on attachment 311392 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=311392&action=review

> Source/WebInspectorUI/UserInterface/Views/SearchSidebarPanel.js:418
> +            performSearchLink.textContent = WebInspector.UIString("Search Again");

Neat! I'd like this better if it was a rounded rect button, not a link.
Comment 4 Devin Rousso 2017-06-02 10:08:52 PDT 
Comment on attachment 311392 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=311392&action=review

>> Source/WebInspectorUI/UserInterface/Views/SearchSidebarPanel.js:418
>> +            performSearchLink.textContent = WebInspector.UIString("Search Again");
> 
> Neat! I'd like this better if it was a rounded rect button, not a link.

I was following the style of the Debugger sidebar, both when breakpoints are off and when a timeline is active.  Do you think it should be an "active" button (with the blue color)?  What were you thinking in terms of the button's style?
Comment 5 Timothy Hatcher 2017-06-02 10:20:32 PDT 
Comment on attachment 311392 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=311392&action=review

>>> Source/WebInspectorUI/UserInterface/Views/SearchSidebarPanel.js:418
>>> +            performSearchLink.textContent = WebInspector.UIString("Search Again");
>> 
>> Neat! I'd like this better if it was a rounded rect button, not a link.
> 
> I was following the style of the Debugger sidebar, both when breakpoints are off and when a timeline is active.  Do you think it should be an "active" button (with the blue color)?  What were you thinking in terms of the button's style?

If we have other cases of this style, then that is fine.
Comment 6 WebKit Commit Bot 2017-06-02 13:57:21 PDT 
Comment on attachment 311392 [details]
Patch

Clearing flags on attachment: 311392

Committed r217733: <http://trac.webkit.org/changeset/217733>
Comment 7 WebKit Commit Bot 2017-06-02 13:57:22 PDT 
All reviewed patches have been landed.  Closing bug.