RESOLVED FIXED 172656
[CMake] Consolidate CMake code related to FreeType 
https://bugs.webkit.org/show_bug.cgi?id=172656
Summary [CMake] Consolidate CMake code related to FreeType
Don Olmstead
Reported 2017-05-26 13:05:33 PDT
Centralize FreeType related CMake definitions.
Attachments
Patch (7.36 KB, patch)
2017-05-26 13:40 PDT, Don Olmstead 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Don Olmstead
Comment 1 2017-05-26 13:40:25 PDT
Created attachment 311371 [details] Patch This consolidates all FreeType/Harfbuzz/Fontconfig files. Currently all of these AND cairo are tightly coupled. Will save busting that out when moving it to the PAL layer.
Don Olmstead
Comment 2 2017-05-26 13:53:22 PDT
Comment on attachment 311371 [details] Patch GTK is green so I think this is good to review! There aren't any WPE bots so hopefully there are no issues with it.
Michael Catanzaro
Comment 3 2017-05-26 14:12:54 PDT
Comment on attachment 311371 [details] Patch I'm sure an EWS for WPE is on the way. Anyway, it seems fine to me to consolidate all the FreeType/Fontconfig/Harfbuzz code under a FreeType.cmake. Let's do it.
Don Olmstead
Comment 4 2017-05-26 14:31:16 PDT
(In reply to Michael Catanzaro from comment #3) > Comment on attachment 311371 [details] > Patch > > I'm sure an EWS for WPE is on the way. Anyway, it seems fine to me to > consolidate all the FreeType/Fontconfig/Harfbuzz code under a > FreeType.cmake. Let's do it. Great! Thanks for the review!
WebKit Commit Bot
Comment 5 2017-05-26 14:41:22 PDT
Comment on attachment 311371 [details] Patch Clearing flags on attachment: 311371 Committed r217508: <http://trac.webkit.org/changeset/217508>
WebKit Commit Bot
Comment 6 2017-05-26 14:41:24 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 7 2017-05-30 20:20:32 PDT
<rdar://problem/32479677>
Note You need to log in before you can comment on or make changes to this bug.