After r217459, we get: ... 2017-05-26 12:15:07.775 testapi[92608:83259983] TEST: "Should not throw an exception when wrapping NSObject and Object has been changed": FAILED ... FAIL: Some tests failed.
Created attachment 311386 [details] Patch
Comment on attachment 311386 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=311386&action=review r=me with suggestion. > Source/JavaScriptCore/ChangeLog:8 > + Fix the test to make sure we don't not check for an exception. How about rephrasing this as: The test's intent is to assert that an exception has not been thrown (as indicated by the message string), but the test was erroneously checking for the opposite condition. This is now fixed.
Comment on attachment 311386 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=311386&action=review >> Source/JavaScriptCore/ChangeLog:8 >> + Fix the test to make sure we don't not check for an exception. > > How about rephrasing this as: > The test's intent is to assert that an exception has not been thrown (as indicated by the message string), but the test was erroneously checking for the opposite condition. This is now fixed. I changed it to: "The test's intent is to assert that an exception has not been thrown (as indicated by the message string), but the test was erroneously checking for !! the condition. This is now fixed." gotta preserve my pun..
Actually, make that: The test's intent is to assert that an exception has not been thrown (as indicated by the message string), but the test was erroneously checking for ! the right condition. This is now fixed.
Created attachment 311402 [details] Patch for landing
Comment on attachment 311402 [details] Patch for landing Clearing flags on attachment: 311402 Committed r217517: <http://trac.webkit.org/changeset/217517>
All reviewed patches have been landed. Closing bug.
<rdar://problem/32479700>