Bug 172651 - REGRESSION(216914): testCFStrings encounters an invalid ExecState callee pointer.
Summary: REGRESSION(216914): testCFStrings encounters an invalid ExecState callee poin...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mark Lam
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-05-26 11:23 PDT by Mark Lam
Modified: 2017-05-30 20:21 PDT (History)
6 users (show)

See Also:


Attachments
proposed patch. (2.01 KB, patch)
2017-05-26 11:28 PDT, Mark Lam
saam: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Lam 2017-05-26 11:23:49 PDT
This is because the assertion utility functions used in testCFStrings() expects to get the JSGlobalContextRef from the global context variable.  However, testCFStrings() creates its own JSGlobalContextRef but does not set the global context variable to it.
Comment 1 Mark Lam 2017-05-26 11:28:37 PDT
Created attachment 311363 [details]
proposed patch.
Comment 2 Mark Lam 2017-05-26 11:46:25 PDT
Thanks for the review.  Landed in r217498: <http://trac.webkit.org/r217498>.
Comment 3 Radar WebKit Bug Importer 2017-05-30 20:21:12 PDT
<rdar://problem/32479707>