Bug 172649 – webrtc/peer-connection-audio-mute.html is sometimes flaky

• Status: RESOLVED
• Resolution: FIXED
• Component: Media

[youenn fablet]

webrtc/peer-connection-audio-mute.html is sometimes flaky

[youenn fablet]

Created attachment 311360 [details]
Patch

[Chris Dumez]

Comment on attachment 311360 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=311360&action=review

> LayoutTests/webrtc/peer-connection-audio-mute.html:13
> +    function ensureHumIsAsExpected(remoteStream, heardHum, count)

I think we should rename heardHum here to shouldHeadHum since this is an expected result, not a result.

[youenn fablet]

Created attachment 311362 [details]
Fixing according comments

[youenn fablet]

Thanks for the review.

(In reply to Chris Dumez from comment #2)
> Comment on attachment 311360 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=311360&action=review
> 
> > LayoutTests/webrtc/peer-connection-audio-mute.html:13
> > +    function ensureHumIsAsExpected(remoteStream, heardHum, count)
> 
> I think we should rename heardHum here to shouldHeadHum since this is an
> expected result, not a result.

Done

[WebKit Commit Bot]

Comment on attachment 311362 [details]
Fixing according comments

Rejecting attachment 311362 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-02', 'apply-attachment', '--no-update', '--non-interactive', 311362, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Last 500 characters of output:
/Scripts/svn-apply', '--force']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Parsed 2 diffs from patch file(s).
patching file LayoutTests/ChangeLog
Hunk #1 succeeded at 1 with fuzz 3.
patching file LayoutTests/webrtc/peer-connection-audio-mute.html
Hunk #1 FAILED at 10.
1 out of 1 hunk FAILED -- saving rejects to file LayoutTests/webrtc/peer-connection-audio-mute.html.rej

Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Full output: http://webkit-queues.webkit.org/results/3822924

[Ryan Haddad]

Can we get this updated and landed? This test is flaky on EWS.

[Ryan Haddad]

Marked test as flaky in http://trac.webkit.org/projects/webkit/changeset/217670

[Matt Lewis]

This test has recently started to crash as well. See Radar: <rdar://problem/33712305>

[Ryan Haddad]

This test is still a flaky failure: 

https://build.webkit.org/results/Apple%20Sierra%20Release%20WK2%20(Tests)/r222338%20(4463)/results.html

https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=webrtc%2Fpeer-connection-audio-mute.html

[Ryan Haddad]

Marked test as flaky again in https://trac.webkit.org/r222345

[youenn fablet]

Created attachment 321495 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 321495 [details]
Patch

Clearing flags on attachment: 321495

Committed r222447: <http://trac.webkit.org/changeset/222447>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/34694160>