Bug 172638 - [CMake] Pass -fdiagnostics-color=always to GCC when building with Ninja
Summary: [CMake] Pass -fdiagnostics-color=always to GCC when building with Ninja
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Adrian Perez
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-05-26 02:33 PDT by Adrian Perez
Modified: 2017-05-30 20:20 PDT (History)
6 users (show)

See Also:

Attachments
Patch (1.91 KB, patch)
2017-05-26 02:36 PDT, Adrian Perez 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Adrian Perez 2017-05-26 02:33:17 PDT 
It would be nice to make GCC generate colored warning/error messages
when building with Ninja. In “OptionsCommon.cmake” there is code to
enable this for Clang, and it should be possible to do something
similar for GCC.
Comment 1 Adrian Perez 2017-05-26 02:36:04 PDT 
Created attachment 311346 [details]
Patch
Comment 2 Yusuke Suzuki 2017-05-26 02:38:20 PDT 
Comment on attachment 311346 [details]
Patch

r=me, nice
Comment 3 WebKit Commit Bot 2017-05-26 03:16:09 PDT 
Comment on attachment 311346 [details]
Patch

Clearing flags on attachment: 311346

Committed r217485: <http://trac.webkit.org/changeset/217485>
Comment 4 WebKit Commit Bot 2017-05-26 03:16:11 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 5 Radar WebKit Bug Importer 2017-05-30 20:20:54 PDT 
<rdar://problem/32479694>