Bug 172633 - Only include DataDetectorsUI headers in iOS
Summary: Only include DataDetectorsUI headers in iOS
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ryosuke Niwa
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-05-25 23:43 PDT by Ryosuke Niwa
Modified: 2017-05-30 14:54 PDT (History)
6 users (show)

See Also:

Attachments
Patch (1.32 KB, patch)
2017-05-25 23:44 PDT, Ryosuke Niwa 		no flags Details | Formatted Diff | Diff
Disables data detections entirely (19.81 KB, patch)
2017-05-26 23:41 PDT, Ryosuke Niwa 		no flags Details | Formatted Diff | Diff
Patch for landing (20.17 KB, patch)
2017-05-30 11:31 PDT, Ryosuke Niwa 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ryosuke Niwa 2017-05-25 23:43:39 PDT 
Don't always include DataDetectorsUI headers
Comment 1 Ryosuke Niwa 2017-05-25 23:44:50 PDT 
Created attachment 311339 [details]
Patch
Comment 2 David Kilzer (:ddkilzer) 2017-05-26 20:29:01 PDT 
Comment on attachment 311339 [details]
Patch

r=me
Comment 3 Ryosuke Niwa 2017-05-26 23:41:59 PDT 
Created attachment 311416 [details]
Disables data detections entirely
Comment 4 Ryosuke Niwa 2017-05-26 23:42:48 PDT 
<rdar://problem/22739993>
Comment 5 David Kilzer (:ddkilzer) 2017-05-30 11:22:03 PDT 
Comment on attachment 311416 [details]
Disables data detections entirely

View in context: https://bugs.webkit.org/attachment.cgi?id=311416&action=review

r=me

> Source/WTF/wtf/Platform.h:552
>  #define HAVE_AVKIT 1
>  #define HAVE_PARENTAL_CONTROLS 1
> +#define ENABLE_DATA_DETECTION 1

Nit:  Please alphabetize by full macro name (so ENABLE_* would come before HAVE_*).

> Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm:56
> +#if ENABLE(DATA_DETECTION)
>  #import "WKDataDetectorTypesInternal.h"
> +#endif

Are we still putting these in a separate section after the default list of #import statements?

> Source/WebKit2/WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInRangeHandle.mm:34
> +#if ENABLE(DATA_DETECTION)
>  #import "WKDataDetectorTypesInternal.h"
> +#endif

Move to after default list of #import statements?
Comment 6 Ryosuke Niwa 2017-05-30 11:31:11 PDT 
Created attachment 311521 [details]
Patch for landing
Comment 7 Ryosuke Niwa 2017-05-30 11:32:09 PDT 
Comment on attachment 311521 [details]
Patch for landing

Wait for EWS.
Comment 8 Ryosuke Niwa 2017-05-30 11:32:16 PDT 
Thanks for the review!
Comment 9 WebKit Commit Bot 2017-05-30 14:54:56 PDT 
Comment on attachment 311521 [details]
Patch for landing

Clearing flags on attachment: 311521

Committed r217580: <http://trac.webkit.org/changeset/217580>
Comment 10 WebKit Commit Bot 2017-05-30 14:54:57 PDT 
All reviewed patches have been landed.  Closing bug.