Bug 172626 – [iOS] Disable async image decoding when synchronously painting a newly parented WKWebView

• Status: RESOLVED
• Resolution: FIXED
• Component: Images

[Said Abou-Hallawa]

When brining a WebView to the foreground we have to draw the page synchronously so the user does not see empty rectangles in the window. This means the large images has to be synchronously decoded as well so the user does not see flashes in the page because the images are not ready to paint.

[Said Abou-Hallawa]

<rdar://problem/32414363>

[Radar WebKit Bug Importer]

<rdar://problem/32417948>

[Said Abou-Hallawa]

<rdar://problem/32414363>

[Said Abou-Hallawa]

Created attachment 311324 [details]
Patch

[Tim Horton]

Comment on attachment 311324 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=311324&action=review

> Source/WebKit2/ChangeLog:8
> +        Large images has to be synchronously decoded when brining a WebView to the

have to be; bringing; because we want the whole page to be painted when we unblock the UI process

> Source/WebKit2/WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.mm:384
> +    m_remoteLayerTreeContext->setNextFlushIsForImmediatePaint(m_nextFlushIsForImmediatePaint = false);

whaaaaat please don't do this weird compound statement

[Said Abou-Hallawa]

Created attachment 311326 [details]
Patch

[Jon Lee]

Comment on attachment 311326 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=311326&action=review

> Source/WebKit2/ChangeLog:3
> +        [iOS] Disbale Async image decoding when synchronously painting a newly parented WebView

Disable async

[Said Abou-Hallawa]

Created attachment 311331 [details]
Patch

[Said Abou-Hallawa]

Created attachment 311332 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 311332 [details]
Patch

Rejecting attachment 311332 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-01', 'validate-changelog', '--check-oops', '--non-interactive', 311332, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

ChangeLog entry in Source/WebKit2/ChangeLog contains OOPS!.

Full output: http://webkit-queues.webkit.org/results/3819454

[WebKit Commit Bot]

Comment on attachment 311332 [details]
Patch

Clearing flags on attachment: 311332

Committed r217475: <http://trac.webkit.org/changeset/217475>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.