Bug 172608 – Web Inspector: The CodeMirror instance in the ConsolePrompt does't need to be refreshed each time it is shown

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector

[Devin Rousso]

Since ConsolePrompt is a subclass of View, we only need to refresh when it has a layout().

[Devin Rousso]

Created attachment 311287 [details]
Patch

[Devin Rousso]

Created attachment 311288 [details]
[Image] Timeline Before

[Devin Rousso]

Created attachment 311289 [details]
[Image] Timeline After

[Build Bot]

Comment on attachment 311287 [details]
Patch

Attachment 311287 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/3816951

New failing tests:
http/tests/preload/viewport/meta-viewport-link-headers.php

[Build Bot]

Created attachment 311303 [details]
Archive of layout-test-results from ews126 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews126  Port: ios-simulator-wk2  Platform: Mac OS X 10.12.5

[Timothy Hatcher]

Comment on attachment 311287 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=311287&action=review

Okay, as long as you tested this well!

> Source/WebInspectorUI/UserInterface/Views/ConsolePrompt.js:-120
> -        this._codeMirror.refresh();

I think we did this because CodeMirror gets in a bad state when it has been hidden/out of the document. Specifically the caret would be broken.

[Devin Rousso]

Comment on attachment 311287 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=311287&action=review

>> Source/WebInspectorUI/UserInterface/Views/ConsolePrompt.js:-120
>> -        this._codeMirror.refresh();
> 
> I think we did this because CodeMirror gets in a bad state when it has been hidden/out of the document. Specifically the caret would be broken.

I don't think the ConsolePrompt is ever out of the document, seeing as it is visible on every tab.  In the case of the DatabaseContentView, I saw no noticeable difference between my change and ToT.

[WebKit Commit Bot]

Comment on attachment 311287 [details]
Patch

Clearing flags on attachment: 311287

Committed r217746: <http://trac.webkit.org/changeset/217746>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.