Bug 172606 – Web Inspector: Changing the width of a Sidebar when it's collapsed shouldn't trigger a layout

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector

[Devin Rousso]

When changing tabs, the previously saved width's of the navigation and details sidebars are both applied to the sidebar elements, each of which triggers a layout of the main content.  If the sidebar is collapsed, changing the width shouldn't trigger a layout as there is no change to what is displayed.

[Devin Rousso]

Created attachment 311281 [details]
Patch

[Devin Rousso]

Created attachment 311282 [details]
[Image] Timeline Before

[Devin Rousso]

Created attachment 311283 [details]
[Image] Timeline After

[Matt Baker]

Maybe Sidebar shouldn't dispatch the event at all when collapsed. That would make it easier for WidthDidChange listeners to always do the right thing, without needing to check if the sidebar is collapsed.

[Joseph Pecoraro]

Comment on attachment 311281 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=311281&action=review

> Source/WebInspectorUI/UserInterface/Base/Main.js:1630
>  WebInspector._sidebarWidthDidChange = function(event)
>  {
> +    if (event.target.collapsed)
> +        return;
> +
>      this._tabBrowserSizeDidChange();
>  };

This does not appear to be correct. When a tab is collapsed we want to run _tabBrowserSizeDidChange.

[Devin Rousso]

Created attachment 311292 [details]
Patch

[Matt Baker]

Comment on attachment 311292 [details]
Patch

r=me

[WebKit Commit Bot]

Comment on attachment 311292 [details]
Patch

Clearing flags on attachment: 311292

Committed r217452: <http://trac.webkit.org/changeset/217452>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/32479717>