Bug 172604 - Regression(r215686): Videos sometimes do not load in iBooks
Summary: Regression(r215686): Videos sometimes do not load in iBooks
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL: https://trac.webkit.org/changeset/215...
Keywords: InRadar
Depends on:
Blocks: 170956
  Show dependency tree / graph
 
Reported: 2017-05-25 12:57 PDT by Chris Dumez
Modified: 2017-05-25 15:20 PDT (History)
7 users (show)

See Also:

Attachments
Patch (3.14 KB, patch)
2017-05-25 14:37 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2017-05-25 12:57:59 PDT 
Videos sometimes do not load in iBooks after r215686.
Comment 1 Chris Dumez 2017-05-25 12:58:17 PDT 
<rdar://problem/32003717>
Comment 2 Chris Dumez 2017-05-25 14:37:34 PDT 
Created attachment 311294 [details]
Patch
Comment 3 Geoffrey Garen 2017-05-25 14:43:10 PDT 
Comment on attachment 311294 [details]
Patch

r=me

This seems like another case where SharedBuffer could offer a helper function to encapsulate behavior and avoid bugs.

In this case, I would offer a function that returned a boolean indicating whether it satisfied the full read request.
Comment 4 WebKit Commit Bot 2017-05-25 15:20:17 PDT 
Comment on attachment 311294 [details]
Patch

Clearing flags on attachment: 311294

Committed r217453: <http://trac.webkit.org/changeset/217453>
Comment 5 WebKit Commit Bot 2017-05-25 15:20:19 PDT 
All reviewed patches have been landed.  Closing bug.