Gracefully handle failures in websockets on wincairo
Created attachment 311211 [details] Patch
Comment on attachment 311211 [details] Patch Attachment 311211 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/3811988 New failing tests: fetch/closing-while-fetching-blob.html
Created attachment 311213 [details] Archive of layout-test-results from ews125 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews125 Port: ios-simulator-wk2 Platform: Mac OS X 10.12.5
Comment on attachment 311211 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=311211&action=review > Source/WebCore/ChangeLog:3 > + Handle failures in websocket on wincairo This is a great thing. Sorry I didn't notice this patch earlier. Let's polish it up and land it. > Source/WebCore/platform/network/curl/SocketStreamHandleImplCurl.cpp:283 > + callOnMainThread([this, ret] { > + // Check reference count to fix a crash. This is a bad pattern I think we shouldn't expand upon. Capture protectedThis = makeRef(*this) to make sure this isn't deallocated underneath us while waiting for the lambda to be called on another thread.
Issac is this something you're going to complete? If not could you let us know so we can assign someone over to take a look?
Hi Don, Sorry I'm not working on this anymore, feel free to take this over.
This is fixed in https://bugs.webkit.org/show_bug.cgi?id=172630.