Bug 172581 - Add some release logging for media elements
Summary: Add some release logging for media elements
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: youenn fablet
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-05-24 22:26 PDT by youenn fablet
Modified: 2017-05-30 20:21 PDT (History)
6 users (show)

See Also:


Attachments
Patch (11.44 KB, patch)
2017-05-24 22:30 PDT, youenn fablet
no flags Details | Formatted Diff | Diff
Patch (11.51 KB, patch)
2017-05-24 22:41 PDT, youenn fablet
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description youenn fablet 2017-05-24 22:26:10 PDT
This will help debugging.
Comment 1 youenn fablet 2017-05-24 22:30:00 PDT
Created attachment 311200 [details]
Patch
Comment 2 youenn fablet 2017-05-24 22:41:52 PDT
Created attachment 311201 [details]
Patch
Comment 3 WebKit Commit Bot 2017-05-25 10:50:00 PDT
Comment on attachment 311201 [details]
Patch

Clearing flags on attachment: 311201

Committed r217436: <http://trac.webkit.org/changeset/217436>
Comment 4 WebKit Commit Bot 2017-05-25 10:50:02 PDT
All reviewed patches have been landed.  Closing bug.
Comment 5 Simon Fraser (smfr) 2017-05-25 11:24:37 PDT
Comment on attachment 311201 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=311201&action=review

> Source/WebCore/platform/mediastream/mac/RealtimeIncomingVideoSource.cpp:134
> +    if (!(++m_numberOfFrames % 30))
> +        RELEASE_LOG(MediaStream, "RealtimeIncomingVideoSource::OnFrame %zu frame", m_numberOfFrames);

I guess this logs about once per second. Can we reduce it a bit?

> Source/WebCore/platform/mediastream/mac/RealtimeOutgoingVideoSource.cpp:151
> +    RELEASE_LOG(MediaStream, "RealtimeOutgoingVideoSource::sendOneBlackFrame");

How verbose will this be?

> Source/WebCore/platform/mediastream/mac/RealtimeOutgoingVideoSource.cpp:178
> +    if (!(++m_numberOfFrames % 30))
> +        RELEASE_LOG(MediaStream, "RealtimeOutgoingVideoSource::sendFrame %zu frame", m_numberOfFrames);

I guess this logs about once per second. Can we reduce it a bit?
Comment 6 youenn fablet 2017-05-25 11:34:29 PDT
(In reply to Simon Fraser (smfr) from comment #5)
> Comment on attachment 311201 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=311201&action=review
> 
> > Source/WebCore/platform/mediastream/mac/RealtimeIncomingVideoSource.cpp:134
> > +    if (!(++m_numberOfFrames % 30))
> > +        RELEASE_LOG(MediaStream, "RealtimeIncomingVideoSource::OnFrame %zu frame", m_numberOfFrames);
> 
> I guess this logs about once per second. Can we reduce it a bit?

What would be a good tradeoff?

> > Source/WebCore/platform/mediastream/mac/RealtimeOutgoingVideoSource.cpp:151
> > +    RELEASE_LOG(MediaStream, "RealtimeOutgoingVideoSource::sendOneBlackFrame");
> 
> How verbose will this be?

1 per second
Comment 7 youenn fablet 2017-05-25 11:45:16 PDT
For incoming frames, we could only log frame size changes, which would reduce to usually ensure that we received one frame out of libwebrtc.
Then we could punt on getStats logging that we could trigger from time to time.
Comment 8 Radar WebKit Bug Importer 2017-05-30 20:21:59 PDT
<rdar://problem/32479732>