RESOLVED FIXED 172581
Add some release logging for media elements 
https://bugs.webkit.org/show_bug.cgi?id=172581
Summary Add some release logging for media elements
youenn fablet
Reported 2017-05-24 22:26:10 PDT
This will help debugging.
Attachments
Patch (11.44 KB, patch)
2017-05-24 22:30 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
Patch (11.51 KB, patch)
2017-05-24 22:41 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
youenn fablet
Comment 1 2017-05-24 22:30:00 PDT
Created attachment 311200 [details] Patch
youenn fablet
Comment 2 2017-05-24 22:41:52 PDT
Created attachment 311201 [details] Patch
WebKit Commit Bot
Comment 3 2017-05-25 10:50:00 PDT
Comment on attachment 311201 [details] Patch Clearing flags on attachment: 311201 Committed r217436: <http://trac.webkit.org/changeset/217436>
WebKit Commit Bot
Comment 4 2017-05-25 10:50:02 PDT
All reviewed patches have been landed. Closing bug.
Simon Fraser (smfr)
Comment 5 2017-05-25 11:24:37 PDT
Comment on attachment 311201 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=311201&action=review > Source/WebCore/platform/mediastream/mac/RealtimeIncomingVideoSource.cpp:134 > + if (!(++m_numberOfFrames % 30)) > + RELEASE_LOG(MediaStream, "RealtimeIncomingVideoSource::OnFrame %zu frame", m_numberOfFrames); I guess this logs about once per second. Can we reduce it a bit? > Source/WebCore/platform/mediastream/mac/RealtimeOutgoingVideoSource.cpp:151 > + RELEASE_LOG(MediaStream, "RealtimeOutgoingVideoSource::sendOneBlackFrame"); How verbose will this be? > Source/WebCore/platform/mediastream/mac/RealtimeOutgoingVideoSource.cpp:178 > + if (!(++m_numberOfFrames % 30)) > + RELEASE_LOG(MediaStream, "RealtimeOutgoingVideoSource::sendFrame %zu frame", m_numberOfFrames); I guess this logs about once per second. Can we reduce it a bit?
youenn fablet
Comment 6 2017-05-25 11:34:29 PDT
(In reply to Simon Fraser (smfr) from comment #5) > Comment on attachment 311201 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=311201&action=review > > > Source/WebCore/platform/mediastream/mac/RealtimeIncomingVideoSource.cpp:134 > > + if (!(++m_numberOfFrames % 30)) > > + RELEASE_LOG(MediaStream, "RealtimeIncomingVideoSource::OnFrame %zu frame", m_numberOfFrames); > > I guess this logs about once per second. Can we reduce it a bit? What would be a good tradeoff? > > Source/WebCore/platform/mediastream/mac/RealtimeOutgoingVideoSource.cpp:151 > > + RELEASE_LOG(MediaStream, "RealtimeOutgoingVideoSource::sendOneBlackFrame"); > > How verbose will this be? 1 per second
youenn fablet
Comment 7 2017-05-25 11:45:16 PDT
For incoming frames, we could only log frame size changes, which would reduce to usually ensure that we received one frame out of libwebrtc. Then we could punt on getStats logging that we could trigger from time to time.
Radar WebKit Bug Importer
Comment 8 2017-05-30 20:21:59 PDT
<rdar://problem/32479732>
Note You need to log in before you can comment on or make changes to this bug.