Use a typedef for SVG resource mode flags union

[Simon Fraser (smfr)]

Use a typedef for SVG resource mode flags union

[Simon Fraser (smfr)]

Created attachment 311196 [details]
Patch

[Build Bot]

Comment on attachment 311196 [details]
Patch

Attachment 311196 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/3811353

New failing tests:
http/tests/cache/cancel-during-revalidation-succeeded.html

[Build Bot]

Created attachment 311209 [details]
Archive of layout-test-results from ews124 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews124  Port: ios-simulator-wk2  Platform: Mac OS X 10.12.5

[Sam Weinig]

Comment on attachment 311196 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=311196&action=review

> Source/WebCore/rendering/svg/RenderSVGResource.h:48
> +typedef unsigned RenderSVGResourceMode;

Maybe use OptionSet<RenderSVGResourceModes> instead. If you want to keep it an unsigned, I would recommend using a type alias instead:

using RenderSVGResourceMode = unsigned;

It's not substantially different, just the syntax we have been moving toward, since it supports things like templated type aliases.

[Simon Fraser (smfr)]

Created attachment 311322 [details]
Patch

[Sam Weinig]

Comment on attachment 311322 [details]
Patch

Nice.

[WebKit Commit Bot]

Comment on attachment 311322 [details]
Patch

Clearing flags on attachment: 311322

Committed r217463: <http://trac.webkit.org/changeset/217463>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Yusuke Suzuki]

Committed r217468: <http://trac.webkit.org/changeset/217468>

[Simon Fraser (smfr)]

Thanks for the fix. No idea why GTK/WPE would need different includes.

[Radar WebKit Bug Importer]

<rdar://problem/32479769>