Bug 172577 - Syncing script shouldn't schedule a build request when there is a build from another test group in progress
Summary: Syncing script shouldn't schedule a build request when there is a build from ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Perf Dashboard (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ryosuke Niwa
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-05-24 21:16 PDT by Ryosuke Niwa
Modified: 2017-05-25 14:10 PDT (History)
5 users (show)

See Also:

Attachments
Fixes the bug (13.69 KB, patch)
2017-05-24 22:09 PDT, Ryosuke Niwa 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ryosuke Niwa 2017-05-24 21:16:03 PDT 
Apparently the syncing script can end up scheduling a new build request for a test group
when there is an in-progress build request from another test group.
Comment 1 Radar WebKit Bug Importer 2017-05-24 21:16:33 PDT 
<rdar://problem/32395049>
Comment 2 Ryosuke Niwa 2017-05-24 21:44:04 PDT 
When a buildbot gets restarted, it'd re-schedule the currently running build. This can result in multiple builds to be pending simultaneously.

The real problem here is that sync-buildbot.js couldn't recover from this state even through I explicitly add a test case for it because the test case itself was broken.
Comment 3 Ryosuke Niwa 2017-05-24 22:09:38 PDT 
Created attachment 311195 [details]
Fixes the bug
Comment 4 Ryosuke Niwa 2017-05-25 14:10:11 PDT 
Comment on attachment 311195 [details]
Fixes the bug

Clearing flags on attachment: 311195

Committed r217448: <http://trac.webkit.org/changeset/217448>
Comment 5 Ryosuke Niwa 2017-05-25 14:10:13 PDT 
All reviewed patches have been landed.  Closing bug.