RESOLVED FIXED 172570
[CMake][Win] Use WTF_CPU not MSCV_CXX_ARCHITECTURE_ID when determining lib directories 
https://bugs.webkit.org/show_bug.cgi?id=172570
Summary [CMake][Win] Use WTF_CPU not MSCV_CXX_ARCHITECTURE_ID when determining lib di...
Don Olmstead
Reported 2017-05-24 18:57:24 PDT
There aren't any guarantees that someone is compiling through Visual Studio so use WTF_CPU which is already determined in the root CMakeLists.txt
Attachments
Patch (2.53 KB, application/octet-stream)
2017-05-24 19:03 PDT, Don Olmstead 		no flags
Details
Patch (1.23 KB, patch)
2017-05-24 19:04 PDT, Don Olmstead 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Don Olmstead
Comment 1 2017-05-24 19:03:20 PDT
Created attachment 311179 [details] Patch Believe the reporter at https://bugs.webkit.org/show_bug.cgi?id=161864 was hitting this issue when attempting to compile with GCC.
Don Olmstead
Comment 2 2017-05-24 19:04:05 PDT
Created attachment 311180 [details] Patch Fix line endings...
Per Arne Vollan
Comment 3 2017-05-25 10:11:56 PDT
Comment on attachment 311180 [details] Patch r=me.
WebKit Commit Bot
Comment 4 2017-05-25 10:40:16 PDT
Comment on attachment 311180 [details] Patch Clearing flags on attachment: 311180 Committed r217434: <http://trac.webkit.org/changeset/217434>
WebKit Commit Bot
Comment 5 2017-05-25 10:40:18 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 6 2017-05-30 20:24:31 PDT
<rdar://problem/32479785>
Note You need to log in before you can comment on or make changes to this bug.