Bug 172570 - [CMake][Win] Use WTF_CPU not MSCV_CXX_ARCHITECTURE_ID when determining lib directories
Summary: [CMake][Win] Use WTF_CPU not MSCV_CXX_ARCHITECTURE_ID when determining lib di...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Don Olmstead
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-05-24 18:57 PDT by Don Olmstead
Modified: 2017-05-30 20:24 PDT (History)
6 users (show)

See Also:

Attachments
Patch (2.53 KB, application/octet-stream)
2017-05-24 19:03 PDT, Don Olmstead 		no flags Details
Patch (1.23 KB, patch)
2017-05-24 19:04 PDT, Don Olmstead 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Don Olmstead 2017-05-24 18:57:24 PDT 
There aren't any guarantees that someone is compiling through Visual Studio so use WTF_CPU which is already determined in the root CMakeLists.txt
Comment 1 Don Olmstead 2017-05-24 19:03:20 PDT 
Created attachment 311179 [details]
Patch

Believe the reporter at https://bugs.webkit.org/show_bug.cgi?id=161864 was hitting this issue when attempting to compile with GCC.
Comment 2 Don Olmstead 2017-05-24 19:04:05 PDT 
Created attachment 311180 [details]
Patch

Fix line endings...
Comment 3 Per Arne Vollan 2017-05-25 10:11:56 PDT 
Comment on attachment 311180 [details]
Patch

r=me.
Comment 4 WebKit Commit Bot 2017-05-25 10:40:16 PDT 
Comment on attachment 311180 [details]
Patch

Clearing flags on attachment: 311180

Committed r217434: <http://trac.webkit.org/changeset/217434>
Comment 5 WebKit Commit Bot 2017-05-25 10:40:18 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 6 Radar WebKit Bug Importer 2017-05-30 20:24:31 PDT 
<rdar://problem/32479785>