Centralize Cairo cmake code for sharing between ports.
Created attachment 311174 [details] Patch Adds a Cairo.cmake file which unifies the cairo sections of GTK, WinCairo, and WPE. Adds if checks in Gstreamer and image decoder cmake files where applicable. Harfbuzz sources are left unchanged. Another patch will be for freetype, harfbuzz and fontconfig path. Exposes USE_CAIRO to the build with WinCairo so any references there are removed. Compiled successfully on WinCairo.
Attachment 311174 [details] did not pass style-queue: ERROR: Source/WebCore/platform/Cairo.cmake:8: No trailing spaces [whitespace/trailing] [5] ERROR: Source/WebCore/platform/Cairo.cmake:9: There should be no empty line between "platform/graphics/cairo/BackingStoreBackendCairoImpl.cpp" and "platform/graphics/cairo/CairoUtilities.cpp". [list/emptyline] [5] Total errors found: 2 in 11 files If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 311175 [details] Patch Fixing style
Nice!
Comment on attachment 311175 [details] Patch Clearing flags on attachment: 311175 Committed r217404: <http://trac.webkit.org/changeset/217404>
All reviewed patches have been landed. Closing bug.
This broke WPE. Here's the build fix: http://trac.webkit.org/changeset/217410
(In reply to Claudio Saavedra from comment #7) > This broke WPE. Here's the build fix: > > http://trac.webkit.org/changeset/217410 Ugh sorry! EWS for WPE coming anytime soon?
<rdar://problem/32479802>