172554 – [WK1] iframes in layer-backed NSViews are not cleared between successive draws

Bug 172554 - [WK1] iframes in layer-backed NSViews are not cleared between successive draws

Summary: [WK1] iframes in layer-backed NSViews are not cleared between successive draws

Status:	RESOLVED FIXED

Alias:	None

Product:	WebKit
Classification:	Unclassified
Component:	New Bugs (show other bugs)
Version:	WebKit Nightly Build
Hardware:	Unspecified Unspecified

Importance:	P2 Normal
Assignee:	Myles C. Maxfield

URL:
Keywords:	InRadar

Depends on:
Blocks:

Reported:	2017-05-24 13:02 PDT by Myles C. Maxfield
Modified:	2017-05-25 17:43 PDT (History)
CC List:	3 users (show)

See Also:

Attachments
Needs tests (5.15 KB, patch) 2017-05-24 13:02 PDT, Myles C. Maxfield	no flags	Details \| Formatted Diff \| Diff
WIP (9.50 KB, patch) 2017-05-24 17:08 PDT, Myles C. Maxfield	no flags	Details \| Formatted Diff \| Diff
WIP (11.96 KB, patch) 2017-05-25 14:44 PDT, Myles C. Maxfield	no flags	Details \| Formatted Diff \| Diff
WIP (10.67 KB, patch) 2017-05-25 14:46 PDT, Myles C. Maxfield	no flags	Details \| Formatted Diff \| Diff
Patch (20.08 KB, patch) 2017-05-25 15:15 PDT, Myles C. Maxfield	no flags	Details \| Formatted Diff \| Diff
Patch (20.18 KB, patch) 2017-05-25 15:16 PDT, Myles C. Maxfield	simon.fraser: review+	Details \| Formatted Diff \| Diff
Patch for committing (20.26 KB, patch) 2017-05-25 16:54 PDT, Myles C. Maxfield	commit-queue: commit-queue-	Details \| Formatted Diff \| Diff
Show Obsolete (5) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Myles C. Maxfield 2017-05-24 13:02:01 PDT

Update WebHTMLView to match AppKit's layout

Comment 1 Myles C. Maxfield 2017-05-24 13:02:24 PDT

Created attachment 311147 [details]
Needs tests

Comment 2 Myles C. Maxfield 2017-05-24 13:02:56 PDT

<rdar://problem/31274603>

Comment 3 Myles C. Maxfield 2017-05-24 13:18:47 PDT

<rdar://problem/31247133>

Comment 4 Myles C. Maxfield 2017-05-24 17:08:18 PDT

Created attachment 311167 [details]
WIP

Comment 5 Simon Fraser (smfr) 2017-05-24 17:14:21 PDT

Comment on attachment 311167 [details]
WIP

View in context: https://bugs.webkit.org/attachment.cgi?id=311167&action=review

> Source/WebKit/mac/ChangeLog:3
> +        Update WebHTMLView to match AppKit's layout

This title should say something about double-drawing of iframe in layer-backed WebViews

Comment 6 Myles C. Maxfield 2017-05-25 14:44:48 PDT

Created attachment 311295 [details]
WIP

Comment 7 Myles C. Maxfield 2017-05-25 14:46:12 PDT

Created attachment 311296 [details]
WIP

Comment 8 Myles C. Maxfield 2017-05-25 15:15:13 PDT

Created attachment 311299 [details]
Patch

Comment 9 Myles C. Maxfield 2017-05-25 15:16:08 PDT

Created attachment 311300 [details]
Patch

Comment 10 Simon Fraser (smfr) 2017-05-25 15:18:55 PDT

Comment on attachment 311300 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=311300&action=review

> Tools/DumpRenderTree/TestOptions.mm:99
> +bool TestOptions::webViewCompatible(const TestOptions& other) const

Myabe webViewIsCompatibleWithOptions()

Comment 11 Myles C. Maxfield 2017-05-25 16:54:08 PDT

Created attachment 311318 [details]
Patch for committing

Comment 12 WebKit Commit Bot 2017-05-25 17:38:51 PDT

Comment on attachment 311318 [details]
Patch for committing

Rejecting attachment 311318 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-03', 'validate-changelog', '--check-oops', '--non-interactive', 311318, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

ChangeLog entry in LayoutTests/ChangeLog contains OOPS!.

Full output: http://webkit-queues.webkit.org/results/3818297

Comment 13 Myles C. Maxfield 2017-05-25 17:43:03 PDT

Committed r217461: <http://trac.webkit.org/changeset/217461>