Bug 172542 – [GTK][WPE][GSTREAMER_GL] Do not use cairo to copy video textures to an accelerated canvas

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKitGTK

[Miguel Gomez]

Instead of using the current approach of copying the video frame using cairo, use VideoTextureCopierGStreamer, as it's done when copying frames to webgl. This will allow to perform color adjustments with the shader during the GPU, which will be needed as we're going to change the video frames format to BGRA.

[Miguel Gomez]

Created attachment 311124 [details]
Patch

[Build Bot]

Comment on attachment 311124 [details]
Patch

Attachment 311124 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/3807875

New failing tests:
fast/events/before-unload-returnValue.html

[Build Bot]

Created attachment 311138 [details]
Archive of layout-test-results from ews125 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews125  Port: ios-simulator-wk2  Platform: Mac OS X 10.12.5

[Zan Dobersek]

Comment on attachment 311124 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=311124&action=review

> Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:983
> +    unsigned textureID = *reinterpret_cast<unsigned*>(videoFrame.data[0]);

This variable can be set just before the copyVideoTextureToPlatformTexture() call.

> Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:998
> +    RefPtr<cairo_surface_t> surface = adoptRef(cairo_gl_surface_create_for_texture(context->cairoDevice(), CAIRO_CONTENT_COLOR_ALPHA, m_videoTextureCopier->resultTexture(), size.width(), size.height()));
> +    return surface;

This can be in one line.

> Source/WebCore/platform/graphics/gstreamer/VideoTextureCopierGStreamer.cpp:146
> +    // Use our own output texture if we are not given one.
> +    if (!outputTexture)
> +        outputTexture = m_resultTexture;

Do we want to wait with the m_resultTexture creation until this point?

[Zan Dobersek]

Comment on attachment 311124 [details]
Patch

Fine otherwise.

[Miguel Gomez]

Created attachment 311497 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 311497 [details]
Patch

Clearing flags on attachment: 311497

Committed r217551: <http://trac.webkit.org/changeset/217551>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.