Bug 172540 – [Win] Create unique network storage session for each DRT.

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Per Arne Vollan]

During layout testing, each DRT instance should have its own network storage session.

[Per Arne Vollan]

Created attachment 311119 [details]
Patch

[Brent Fulgham]

Comment on attachment 311119 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=311119&action=review

Wow -- I wonder how many problems this has caused in Windows testing over the years!?!  Thanks for fixing this. r=me.

> Source/WebCore/platform/network/cf/NetworkStorageSessionCFNet.cpp:95
> +    session = adoptCF(wkCreatePrivateStorageSession(sessionName.createCFString().get(), defaultStorageSession().platformSession()));

It's weird that we have NetworkStorageSession::defaultStorageSession() and NetworkStorageSession::defaultNetworkStorageSession(). How does anyone know which one to use?

It looks like 'defaultNetworkStorageSession' just returns the (potentially uninitialized) storage session, while 'defaultStorageSession' builds a new one if it doesn't exist.

Maybe this was some kind of optimization, where you only needed to call the more expensive version at launch or something?

[Per Arne Vollan]

(In reply to Brent Fulgham from comment #2)
> Comment on attachment 311119 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=311119&action=review
> 
> Wow -- I wonder how many problems this has caused in Windows testing over
> the years!?!  Thanks for fixing this. r=me.
> 
> > Source/WebCore/platform/network/cf/NetworkStorageSessionCFNet.cpp:95
> > +    session = adoptCF(wkCreatePrivateStorageSession(sessionName.createCFString().get(), defaultStorageSession().platformSession()));
> 
> It's weird that we have NetworkStorageSession::defaultStorageSession() and
> NetworkStorageSession::defaultNetworkStorageSession(). How does anyone know
> which one to use?
> 
> It looks like 'defaultNetworkStorageSession' just returns the (potentially
> uninitialized) storage session, while 'defaultStorageSession' builds a new
> one if it doesn't exist.
> 
> Maybe this was some kind of optimization, where you only needed to call the
> more expensive version at launch or something?

Yes, I had to use defaultStorageSession the first time, otherwise it would crash. Thanks for reviewing!

[WebKit Commit Bot]

Comment on attachment 311119 [details]
Patch

Clearing flags on attachment: 311119

Committed r217370: <http://trac.webkit.org/changeset/217370>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/32479766>