Bug 172528 - We should not mmap zero bytes for a memory in Wasm
Summary: We should not mmap zero bytes for a memory in Wasm
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Saam Barati
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-05-23 15:47 PDT by Saam Barati
Modified: 2017-05-23 17:32 PDT (History)
13 users (show)

See Also:

Attachments
patch (3.99 KB, patch)
2017-05-23 16:09 PDT, Saam Barati 		mark.lam: review+
Details | Formatted Diff | Diff
patch for landing (3.97 KB, patch)
2017-05-23 16:53 PDT, Saam Barati 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Saam Barati 2017-05-23 15:47:47 PDT 
...
Comment 1 Saam Barati 2017-05-23 16:04:03 PDT 
<rdar://problem/32257076>
Comment 2 Saam Barati 2017-05-23 16:09:27 PDT 
Created attachment 311069 [details]
patch
Comment 3 Build Bot 2017-05-23 16:11:07 PDT 
Attachment 311069 [details] did not pass style-queue:


ERROR: Source/JavaScriptCore/ChangeLog:8:  Line contains tab character.  [whitespace/tab] [5]
Total errors found: 1 in 4 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 4 Mark Lam 2017-05-23 16:11:23 PDT 
Comment on attachment 311069 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=311069&action=review

r=me

> Source/JavaScriptCore/ChangeLog:3
> +        We should not mmap a zero bytes for a memory in Wasm

I think you should drop the "a" before "zero bytes".
Comment 5 Saam Barati 2017-05-23 16:53:42 PDT 
Created attachment 311075 [details]
patch for landing
Comment 6 WebKit Commit Bot 2017-05-23 17:32:15 PDT 
Comment on attachment 311075 [details]
patch for landing

Clearing flags on attachment: 311075

Committed r217314: <http://trac.webkit.org/changeset/217314>
Comment 7 WebKit Commit Bot 2017-05-23 17:32:17 PDT 
All reviewed patches have been landed.  Closing bug.