Bug 172524 – Resource Load Statistics: Change grandfathering default to one hour

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit2

[John Wilander]

We should only grandfather website data records for one hour to start with. If more is needed we can bump it up again.

[Radar WebKit Bug Importer]

<rdar://problem/32360462>

[John Wilander]

Created attachment 311051 [details]
Patch

[Brent Fulgham]

Comment on attachment 311051 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=311051&action=review

r=me

> Source/WebKit2/UIProcess/WebResourceLoadStatisticsManager.cpp:152
> +    WebCore::ResourceLoadObserver::sharedObserver().setGrandfatheringTime(3600);

Weird that we can't use "grandfatheringTime" here, instead of a magic number.

[John Wilander]

(In reply to Brent Fulgham from comment #3)
> Comment on attachment 311051 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=311051&action=review
> 
> r=me
> 
> > Source/WebKit2/UIProcess/WebResourceLoadStatisticsManager.cpp:152
> > +    WebCore::ResourceLoadObserver::sharedObserver().setGrandfatheringTime(3600);
> 
> Weird that we can't use "grandfatheringTime" here, instead of a magic number.

Thanks for the review!

grandfatheringTime in ResourceLoadStatisticsStore.cpp is the variable that's changed so we'd have to introduce a constant.

[WebKit Commit Bot]

Comment on attachment 311051 [details]
Patch

Clearing flags on attachment: 311051

Committed r217372: <http://trac.webkit.org/changeset/217372>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.