Bug 172520 – checkGPUStatus needs to exercise instancing calls

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Dean Jackson]

checkGPUStatus needs to exercise instancing calls

[Dean Jackson]

Created attachment 311040 [details]
Patch

[Simon Fraser (smfr)]

Comment on attachment 311040 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=311040&action=review

> Source/WebCore/html/canvas/WebGLRenderingContextBase.h:361
> +    WEBCORE_EXPORT void setFailNextGPUStatusCheck();

Maybe add "ForTesting" to the name here and elsewhere, to make it a bit less mysterious.

[Brent Fulgham]

Comment on attachment 311040 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=311040&action=review

Looks good! I mostly commented just to test my local WebKit build. :-) r=me.

> Source/WebCore/platform/graphics/GraphicsContext3D.h:1441
> +    unsigned m_statusCheckCount { 0 };

It seems like this could overflow if you status check counted enough times. But maybe you reset later?

> Source/WebCore/platform/graphics/mac/GraphicsContext3DMac.mm:65
> +static const unsigned statusCheckThreshold = 5;

I never know when we should be using constexpr. Here? No?

> Source/WebCore/platform/graphics/mac/GraphicsContext3DMac.mm:652
> +    m_statusCheckCount = (m_statusCheckCount + 1) % statusCheckThreshold;

So this resets every statusCheckThreshold counts. Since that's currently set to 5, unsigned might be bigger than we need, but seems fine.

[Dean Jackson]

Committed r217298: <http://trac.webkit.org/changeset/217298>