[iOS Simulator] http/tests/preload/viewport/meta-viewport-link-headers.php is a flaky failure.

[Matt Lewis]

The test http/tests/preload/viewport/meta-viewport-link-headers.php is a flaky failure on iOS Simulator WK2 and consistently fails on iOS Simulator WK1.

The test was implemented in https://trac.webkit.org/changeset/217247/webkit
It has been flaky since the addition.

https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=http%2Ftests%2Fpreload%2Fviewport%2Fmeta-viewport-link-headers.php

https://build.webkit.org/results/Apple%20iOS%2010%20Simulator%20Release%20WK2%20(Tests)/r217280%20(1698)/results.html
https://build.webkit.org/builders/Apple%20iOS%2010%20Simulator%20Release%20WK2%20(Tests)/builds/1698

[Matt Lewis]

diff:
--- /Volumes/Data/slave/ios-simulator-10-release-tests-wk2/build/layout-test-results/http/tests/preload/viewport/meta-viewport-link-headers-expected.txt
+++ /Volumes/Data/slave/ios-simulator-10-release-tests-wk2/build/layout-test-results/http/tests/preload/viewport/meta-viewport-link-headers-actual.txt
@@ -1,3 +1,3 @@
 
-PASS Makes sure that Link headers support the media attribute and respond to <meta content=viewport> 
+FAIL Makes sure that Link headers support the media attribute and respond to <meta content=viewport> assert_true: expected true got false

[Yoav Weiss]

I'll look into that. Is it also flaky on ios?

[Alexey Proskuryakov]

We only run the tests on simulator, so if you are asking about device, then I don't have an answer.

[Matt Lewis]

Marked test as flaky.

https://trac.webkit.org/changeset/217612/webkit/

[Jonathan Bedard]

Yoav, we have recently gotten layout tests running on iOS devices internally. This test is behaving the same way on devices as it is in the simulator.

Moved the test expectation in <https://trac.webkit.org/changeset/221142/webkit/>

[Yoav Weiss]

Apologies. This has fallen off my radar. I'll take a look

[Yoav Weiss]

Created attachment 319177 [details]
Patch

[Yoav Weiss]

Hey Youenn :)
Care to take a look at this new and improved test patch?

[youenn fablet]

Comment on attachment 319177 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=319177&action=review

> LayoutTests/http/tests/preload/viewport/meta-viewport-link-headers.php:32
> +        }, 200);

200 might not be large enough.
One approach would be to check for controlLoaded/smallLoaded every 50 ms or so.
If both are not true after 10 or 20 tries, test would fail.
Once both are true, a last check that largeLoaded is false could be done.

[Yoav Weiss]

Created attachment 319851 [details]
Patch

[Yoav Weiss]

(In reply to youenn fablet from comment #9)
> Comment on attachment 319177 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=319177&action=review
> 
> > LayoutTests/http/tests/preload/viewport/meta-viewport-link-headers.php:32
> > +        }, 200);
> 
> 200 might not be large enough.
> One approach would be to check for controlLoaded/smallLoaded every 50 ms or
> so.
> If both are not true after 10 or 20 tries, test would fail.
> Once both are true, a last check that largeLoaded is false could be done.

Changed to iterate over 50 ms intervals. PTAL :)

[Yoav Weiss]

Created attachment 319853 [details]
Patch

[Yoav Weiss]

Comment on attachment 319853 [details]
Patch

Thanks for reviewing! :)

[WebKit Commit Bot]

Comment on attachment 319853 [details]
Patch

Clearing flags on attachment: 319853

Committed r221604: <http://trac.webkit.org/changeset/221604>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/34694137>