Bug 172512 - CoreAudioCaptureSource is ducking system sound
Summary: CoreAudioCaptureSource is ducking system sound
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: youenn fablet
URL:
Keywords: InRadar
Depends on: 172538
Blocks:
  Show dependency tree / graph
 
Reported: 2017-05-23 11:11 PDT by youenn fablet
Modified: 2017-05-24 11:56 PDT (History)
4 users (show)

See Also:

Attachments
Patch (1.54 KB, patch)
2017-05-23 11:13 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
Patch (2.69 KB, patch)
2017-05-23 16:12 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
Patch (19.03 KB, patch)
2017-05-23 16:34 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
Patch (2.95 KB, patch)
2017-05-23 16:54 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
Patch (3.00 KB, patch)
2017-05-23 17:02 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
Patch (3.50 KB, patch)
2017-05-23 17:28 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
Patch (3.21 KB, patch)
2017-05-23 20:00 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
Patch (3.28 KB, patch)
2017-05-23 20:44 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
Patch (3.53 KB, patch)
2017-05-23 20:55 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
Patch (3.54 KB, patch)
2017-05-23 21:12 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
Patch (3.34 KB, patch)
2017-05-23 21:34 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
Adding CoreAudio as framework for ios-sim as well (6.09 KB, patch)
2017-05-24 08:32 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
Patch (11.01 KB, patch)
2017-05-24 10:30 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
Patch (11.21 KB, patch)
2017-05-24 10:58 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
Patch (11.25 KB, patch)
2017-05-24 11:11 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
Show Obsolete (14) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description youenn fablet 2017-05-23 11:11:29 PDT 
This happens on some Macs
Comment 1 youenn fablet 2017-05-23 11:13:23 PDT 
Created attachment 311029 [details]
Patch
Comment 2 youenn fablet 2017-05-23 16:12:06 PDT 
Created attachment 311071 [details]
Patch
Comment 3 Build Bot 2017-05-23 16:14:05 PDT 
Attachment 311071 [details] did not pass style-queue:


ERROR: Source/WebCore/platform/mediastream/mac/CoreAudioCaptureSource.cpp:50:  *SoftLink.h header should be included after all other headers.  [build/include_order] [4]
Total errors found: 1 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 4 youenn fablet 2017-05-23 16:34:14 PDT 
Created attachment 311073 [details]
Patch
Comment 5 Build Bot 2017-05-23 16:40:08 PDT 
Attachment 311073 [details] did not pass style-queue:


ERROR: Source/WebCore/platform/mediastream/mac/CoreAudioCaptureSource.cpp:53:  *SoftLink.h header should be included after all other headers.  [build/include_order] [4]
Total errors found: 1 in 17 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 6 youenn fablet 2017-05-23 16:54:01 PDT 
Created attachment 311076 [details]
Patch
Comment 7 Build Bot 2017-05-23 16:55:10 PDT 
Attachment 311076 [details] did not pass style-queue:


ERROR: Source/WebCore/platform/mediastream/mac/CoreAudioCaptureSource.cpp:53:  *SoftLink.h header should be included after all other headers.  [build/include_order] [4]
Total errors found: 1 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 8 youenn fablet 2017-05-23 17:02:55 PDT 
Created attachment 311079 [details]
Patch
Comment 9 Build Bot 2017-05-23 17:05:34 PDT 
Attachment 311079 [details] did not pass style-queue:


ERROR: Source/WebCore/platform/mediastream/mac/CoreAudioCaptureSource.cpp:53:  *SoftLink.h header should be included after all other headers.  [build/include_order] [4]
Total errors found: 1 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 10 youenn fablet 2017-05-23 17:28:06 PDT 
Created attachment 311084 [details]
Patch
Comment 11 Build Bot 2017-05-23 17:29:57 PDT 
Attachment 311084 [details] did not pass style-queue:


ERROR: Source/WebCore/platform/mediastream/mac/CoreAudioCaptureSource.cpp:54:  *SoftLink.h header should be included after all other headers.  [build/include_order] [4]
Total errors found: 1 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 12 youenn fablet 2017-05-23 20:00:32 PDT 
Created attachment 311092 [details]
Patch
Comment 13 youenn fablet 2017-05-23 20:44:37 PDT 
Created attachment 311095 [details]
Patch
Comment 14 youenn fablet 2017-05-23 20:55:06 PDT 
Created attachment 311096 [details]
Patch
Comment 15 youenn fablet 2017-05-23 21:12:42 PDT 
Created attachment 311097 [details]
Patch
Comment 16 youenn fablet 2017-05-23 21:34:00 PDT 
Created attachment 311098 [details]
Patch
Comment 17 youenn fablet 2017-05-23 22:16:17 PDT 
rdar://problem/32296418
Comment 18 Radar WebKit Bug Importer 2017-05-23 22:16:45 PDT 
<rdar://problem/32370951>
Comment 19 WebKit Commit Bot 2017-05-23 22:39:26 PDT 
Comment on attachment 311098 [details]
Patch

Clearing flags on attachment: 311098

Committed r217319: <http://trac.webkit.org/changeset/217319>
Comment 20 WebKit Commit Bot 2017-05-23 22:39:27 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 21 WebKit Commit Bot 2017-05-24 03:45:14 PDT 
Re-opened since this is blocked by bug 172538
Comment 22 youenn fablet 2017-05-24 08:32:50 PDT 
Created attachment 311120 [details]
Adding CoreAudio as framework for ios-sim as well
Comment 23 youenn fablet 2017-05-24 10:30:31 PDT 
Created attachment 311129 [details]
Patch
Comment 24 youenn fablet 2017-05-24 10:58:06 PDT 
Created attachment 311132 [details]
Patch
Comment 25 youenn fablet 2017-05-24 11:11:03 PDT 
Created attachment 311135 [details]
Patch
Comment 26 WebKit Commit Bot 2017-05-24 11:56:53 PDT 
Comment on attachment 311135 [details]
Patch

Clearing flags on attachment: 311135

Committed r217381: <http://trac.webkit.org/changeset/217381>
Comment 27 WebKit Commit Bot 2017-05-24 11:56:55 PDT 
All reviewed patches have been landed.  Closing bug.