WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
NEW
172511
[WebIDL] Avoid unnecessary exception checks after type conversions
https://bugs.webkit.org/show_bug.cgi?id=172511
Summary
[WebIDL] Avoid unnecessary exception checks after type conversions
Sam Weinig
Reported
2017-05-23 11:07:02 PDT
We currently assume all type conversion (via JSValueToNative) can throw exceptions. This is not strictly true however. A few types: bool, any and date (that may not be the exhaustive list, but its close) never throw, and we should consider optimizing out the calls to check for exception after their conversions. We could either do this via hardcoding them in the code generator, or adding constexprs to the Converters that indicate whether they throw, and checking that before checking for the exception, letting the compiler statically remove the check it would not otherwise be able to eliminate.
Attachments
Add attachment
proposed patch, testcase, etc.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug