As of 2.17.3, about 10% of the pictures on a website are typically broken in a way that looks like a broke decoding or memory violations. One example is attached. Other examples are pictures being interchanged, pictures being mixed together, or random behaviour during redraw (scrolling). I suspect a screenshot alone doesn't help much pinpointing the cause but for now I can not bisect the issue. What might be worth mentioning: Mesa from GIT @ 17.1-branchpoint-1052-g1586768e7 Weston from GIT @ 2.0.0-73-geca5cca5 Happens also under other compositors, all pure Wayland Configured with -DPORT=GTK -DUSE_LD_GOLD=OFF -DUSE_LIBSECRET=OFF -DENABLE_GEOLOCATION=OFF -DENABLE_INTROSPECTION=OFF -DENABLE_MINIBROWSER=ON -DCMAKE_INSTALL_PREFIX=/home/manday/local/ -DCMAKE_BUILD_TYPE=Release -DENABLE_SPELLCHECK=OFF -DUSE_LIBNOTIFY=OFF -DUSE_LIBHYPHEN=OFF
Created attachment 311014 [details] Screenshot of broken rendering
Looks like an image decoders problem, and maybe a separate scrolling bug.
Created attachment 312779 [details] Patch
Attachment 312779 [details] did not pass style-queue: ERROR: Source/WebCore/platform/image-decoders/cairo/ImageBackingStoreCairo.cpp:40: More than one command on the same line [whitespace/newline] [4] Total errors found: 1 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 312779 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=312779&action=review > Source/WebCore/platform/graphics/ImageBackingStore.h:218 > RGBA32* m_pixelsPtr { nullptr }; Could you make this a const RGBA32* to not need to add two const_casts?
Let's give this a better title before landing this. I think this regressed in r216901.
Comment on attachment 312779 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=312779&action=review This looks good to me, please, check if you can use a const RGBA32* as Alex suggested before landing. > Source/WebCore/ChangeLog:3 > + Rendering (accelerated?) badly broken in 2.17.3 Please, update the bug title before landing.
(In reply to Alex Christensen from comment #5) > Comment on attachment 312779 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=312779&action=review > > > Source/WebCore/platform/graphics/ImageBackingStore.h:218 > > RGBA32* m_pixelsPtr { nullptr }; > > Could you make this a const RGBA32* to not need to add two const_casts? There are places in the code where the content of m_pixelsPtr is being changed, so I don't think making it const is an option :(
Created attachment 312876 [details] Patch
Attachment 312876 [details] did not pass style-queue: ERROR: Source/WebCore/platform/image-decoders/cairo/ImageBackingStoreCairo.cpp:40: More than one command on the same line [whitespace/newline] [4] Total errors found: 1 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style.
*** Bug 173360 has been marked as a duplicate of this bug. ***
Comment on attachment 312876 [details] Patch Clearing flags on attachment: 312876 Committed r218253: <http://trac.webkit.org/changeset/218253>
All reviewed patches have been landed. Closing bug.