Bug 172501 – [preload] Conditional support for media preloading and align media `as` values.

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Yoav Weiss]

[preload] Remove support for media preloading.

[Yoav Weiss]

Created attachment 310995 [details]
Patch

[Yoav Weiss]

Created attachment 310999 [details]
Patch

[Sam Weinig]

Rather than removing it, should it be made a setting?

[youenn fablet]

A setting sounds good.

[Yoav Weiss]

Do you want me to plumb the settings all the way to WebKit2/WebProcess/WebPage (like current experimental features, or should it just be an internal setting, turned off by default? Opting for the latter, but let me know if the former is desired.

[Yoav Weiss]

Created attachment 311579 [details]
Patch

[Build Bot]

Comment on attachment 311579 [details]
Patch

Attachment 311579 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/3847461

New failing tests:
http/tests/preload/download_resources.html
http/tests/preload/onerror_event.html
http/tests/preload/single_download_preload.html
http/wpt/preload/type-attribute.html
http/tests/preload/onload_event.html

[Build Bot]

Created attachment 311581 [details]
Archive of layout-test-results from ews112 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews112  Port: mac-elcapitan  Platform: Mac OS X 10.11.6

[Build Bot]

Comment on attachment 311579 [details]
Patch

Attachment 311579 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/3847648

New failing tests:
compositing/masks/compositing-clip-path-change-no-repaint.html

[Build Bot]

Created attachment 311582 [details]
Archive of layout-test-results from ews126 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews126  Port: ios-simulator-wk2  Platform: Mac OS X 10.12.5

[Yoav Weiss]

Created attachment 311583 [details]
Patch

[Build Bot]

Comment on attachment 311583 [details]
Patch

Attachment 311583 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/3848371

New failing tests:
fast/css/target-fragment-match.html

[Build Bot]

Created attachment 311592 [details]
Archive of layout-test-results from ews126 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews126  Port: ios-simulator-wk2  Platform: Mac OS X 10.12.5

[youenn fablet]

Could you turn the flag on for layout tests. Need to update WTR and DYR.
This should remove the need to change the tests.
You can see some examples with options like ice candidate filtering which is off by default but on with DYR/WTR

[Sam Weinig]

(In reply to Yoav Weiss from comment #5)
> Do you want me to plumb the settings all the way to
> WebKit2/WebProcess/WebPage (like current experimental features, or should it
> just be an internal setting, turned off by default? Opting for the latter,
> but let me know if the former is desired.

Just something in Settings.in should suffice, since that can be triggered by the tests.

[Yoav Weiss]

Created attachment 311686 [details]
Patch

[Yoav Weiss]

Created attachment 311694 [details]
Patch

[Yoav Weiss]

Created attachment 311806 [details]
Patch

[Yoav Weiss]

Bots are now green and happy. PTAL?

[Yoav Weiss]

Comment on attachment 311806 [details]
Patch

Thanks for reviewing! :)

[WebKit Commit Bot]

Comment on attachment 311806 [details]
Patch

Rejecting attachment 311806 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-01', 'apply-attachment', '--no-update', '--non-interactive', 311806, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Last 500 characters of output:
der.php
patching file LayoutTests/http/tests/preload/resources/nph-invalid_resources_from_header.pl
patching file LayoutTests/http/tests/preload/single_download_preload.html
patching file LayoutTests/http/tests/preload/single_download_preload_headers.php
patching file LayoutTests/http/tests/preload/single_download_preload_headers_charset.php

Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Dean Jackson']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Full output: http://webkit-queues.webkit.org/results/3883376

[Yoav Weiss]

Created attachment 312125 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 312125 [details]
Patch

Clearing flags on attachment: 312125

Committed r217863: <http://trac.webkit.org/changeset/217863>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.