Bug 172492 - [GTK] Web Inspector: Add a new icon DockLeft.svg
Summary: [GTK] Web Inspector: Add a new icon DockLeft.svg
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Fujii Hironori
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-05-22 23:39 PDT by Fujii Hironori
Modified: 2017-05-23 06:33 PDT (History)
6 users (show)

See Also:


Attachments
Patch (1.94 KB, patch)
2017-05-22 23:45 PDT, Fujii Hironori
no flags Details | Formatted Diff | Diff
screenshot of before and after this fix (RTL is specified) (13.83 KB, image/png)
2017-05-22 23:51 PDT, Fujii Hironori
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Fujii Hironori 2017-05-22 23:39:07 PDT
[GTK] Web Inspector: Add a new icon DockLeft.svg

Apple's proprietary icon has added in Bug 168273.
Comment 1 Fujii Hironori 2017-05-22 23:44:31 PDT
This icon can not be shown in the current GTK port because WebCore::UserInterfaceLayoutDirection::LTR is hard-coded in Source/WebKit2/UIProcess/API/gtk/PageClientImpl.h at the moment.
Comment 2 Fujii Hironori 2017-05-22 23:45:17 PDT
Created attachment 310984 [details]
Patch
Comment 3 Fujii Hironori 2017-05-22 23:51:16 PDT
Created attachment 310985 [details]
screenshot of before and after this fix (RTL is specified)
Comment 4 WebKit Commit Bot 2017-05-23 00:21:24 PDT
Comment on attachment 310984 [details]
Patch

Clearing flags on attachment: 310984

Committed r217271: <http://trac.webkit.org/changeset/217271>
Comment 5 WebKit Commit Bot 2017-05-23 00:21:26 PDT
All reviewed patches have been landed.  Closing bug.
Comment 6 Michael Catanzaro 2017-05-23 06:33:59 PDT
(In reply to Fujii Hironori from comment #1)
> This icon can not be shown in the current GTK port because
> WebCore::UserInterfaceLayoutDirection::LTR is hard-coded in
> Source/WebKit2/UIProcess/API/gtk/PageClientImpl.h at the moment.

Strange. Getting the text direction should be trivial: that's one call to gtk_widget_get_direction() on the WebKitWebView. Or if PageClientImpl doesn't have easy access to the WebKitWebView, a call to gtk_widget_get_default_direction() would work properly 99% of the time.