Bug 172478 - Rename DisplaySleepDisabler -> SleepDisabler
Summary: Rename DisplaySleepDisabler -> SleepDisabler
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jer Noble
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-05-22 16:05 PDT by Jer Noble
Modified: 2017-05-30 20:27 PDT (History)
3 users (show)

See Also:


Attachments
Patch (25.91 KB, patch)
2017-05-22 16:31 PDT, Jer Noble
no flags Details | Formatted Diff | Diff
Patch (30.34 KB, patch)
2017-05-22 16:44 PDT, Jer Noble
no flags Details | Formatted Diff | Diff
Patch for landing (40.64 KB, patch)
2017-05-24 09:02 PDT, Jer Noble
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jer Noble 2017-05-22 16:05:46 PDT
Rename DisplaySleepDisabler -> SleepDisabler
Comment 1 Jer Noble 2017-05-22 16:31:01 PDT
Created attachment 310950 [details]
Patch
Comment 2 Jer Noble 2017-05-22 16:44:12 PDT
Created attachment 310955 [details]
Patch
Comment 3 Sam Weinig 2017-05-22 17:48:27 PDT
Comment on attachment 310955 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=310955&action=review

> Source/WebCore/ChangeLog:3
> +        Rename DisplaySleepDisabler -> SleepDisabler

Seems fine, but could have an explanation of why?
Comment 4 Jer Noble 2017-05-22 18:45:35 PDT
(In reply to Sam Weinig from comment #3)
> Comment on attachment 310955 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=310955&action=review
> 
> > Source/WebCore/ChangeLog:3
> > +        Rename DisplaySleepDisabler -> SleepDisabler
> 
> Seems fine, but could have an explanation of why?

Sure. In a future patch, I’m going to allow clients to distinguish between display sleep and system sleep. I’ll add it to the change log before landing.
Comment 5 Jer Noble 2017-05-24 09:02:21 PDT
Created attachment 311122 [details]
Patch for landing
Comment 6 WebKit Commit Bot 2017-05-24 09:40:00 PDT
Comment on attachment 311122 [details]
Patch for landing

Clearing flags on attachment: 311122

Committed r217371: <http://trac.webkit.org/changeset/217371>
Comment 7 WebKit Commit Bot 2017-05-24 09:40:02 PDT
All reviewed patches have been landed.  Closing bug.
Comment 8 Radar WebKit Bug Importer 2017-05-30 20:27:30 PDT
<rdar://problem/32479834>