RESOLVED FIXED 172470
Web Inspector: use initialLayout for NetworkSidebarPanel 
https://bugs.webkit.org/show_bug.cgi?id=172470
Summary Web Inspector: use initialLayout for NetworkSidebarPanel
Devin Rousso
Reported 2017-05-22 13:42:14 PDT
Also move the creation of the NetworkGridContentView to right before it is shown.
Attachments
Patch (5.45 KB, patch)
2017-05-22 13:44 PDT, Devin Rousso 		joepeck: review+
DetailsFormatted DiffDiff
[Image] Timeline Before (494.19 KB, image/png)
2017-05-22 13:44 PDT, Devin Rousso 		no flags
Details
[Image] Timeline After (483.99 KB, image/png)
2017-05-22 13:45 PDT, Devin Rousso 		no flags
Details
Patch (5.56 KB, patch)
2017-05-23 13:09 PDT, Devin Rousso 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Devin Rousso
Comment 1 2017-05-22 13:44:20 PDT
Created attachment 310910 [details] Patch
Devin Rousso
Comment 2 2017-05-22 13:44:58 PDT
Created attachment 310912 [details] [Image] Timeline Before
Devin Rousso
Comment 3 2017-05-22 13:45:12 PDT
Created attachment 310913 [details] [Image] Timeline After
Joseph Pecoraro
Comment 4 2017-05-22 21:40:42 PDT
Comment on attachment 310910 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=310910&action=review r=me, but with concerns > Source/WebInspectorUI/UserInterface/Views/NetworkSidebarPanel.js:41 > this.contentBrowser.addEventListener(WebInspector.ContentBrowser.Event.CurrentContentViewDidChange, this._contentBrowserCurrentContentViewDidChange, this); As was mentioned previously, it doesn't make sense to me why this is not in initialLayout. It seems potentially problematic keeping it separate. It is quite small right now but I do worry about future changes adding code in there that is unsafe unless performed after initial layout. > Source/WebInspectorUI/UserInterface/Views/NetworkSidebarPanel.js:82 > + var scopeItemPrefix = "network-sidebar-"; Style: Lets upgrade these to `let` now.
Devin Rousso
Comment 5 2017-05-23 13:09:24 PDT
Created attachment 311042 [details] Patch
WebKit Commit Bot
Comment 6 2017-05-23 13:34:55 PDT
Comment on attachment 311042 [details] Patch Clearing flags on attachment: 311042 Committed r217295: <http://trac.webkit.org/changeset/217295>
WebKit Commit Bot
Comment 7 2017-05-23 13:34:57 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.