Bug 172460 – Need a way to allow WKWebView to load request with ShouldOpenExternalURLsPolicy::ShouldAllow.

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit2

[Yongjun Zhang]

Currently, by default, [WKWebView loadRequest:] will set ShouldOpenExternalURLsPolicy to be ShouldNotAllow. It would be nice if a WebKit client can ask WKWebView to load request with ShouldOpenExternalURLsPolicy being ShouldAllow.

[Yongjun Zhang]

rdar://problem/30741139

[Yongjun Zhang]

Created attachment 310898 [details]
Patch.

[Alex Christensen]

Comment on attachment 310898 [details]
Patch.

Sure, but I see no reason why this SPI should be iOS-only.

[Yongjun Zhang]

(In reply to Alex Christensen from comment #3)
> Comment on attachment 310898 [details]
> Patch.
> 
> Sure, but I see no reason why this SPI should be iOS-only.

Currently, this is only needed for iOS. We can certainly expand this to macOS if needed in the future.

We did have the C SPI version in WKPagePrivate.h WKPageLoadURLWithShouldOpenExternalURLsPolicy, and it seems like no one is using it right now.

[Tim Horton]

(In reply to Yongjun Zhang from comment #4)
> (In reply to Alex Christensen from comment #3)
> > Comment on attachment 310898 [details]
> > Patch.
> > 
> > Sure, but I see no reason why this SPI should be iOS-only.
> 
> Currently, this is only needed for iOS. We can certainly expand this to
> macOS if needed in the future.

This isn't how we should add things to a cross-platform framework. We should add to both platforms unless we have a good reason *not* to.

> We did have the C SPI version in WKPagePrivate.h
> WKPageLoadURLWithShouldOpenExternalURLsPolicy, and it seems like no one is
> using it right now.

[Yongjun Zhang]

Created attachment 310922 [details]
Patch, add this SPI for both iOS and macOS.

Address review comment, adding _loadRequest:shouldOpenExternalURLs: as an SPI for both iOS and macOS.

[WebKit Commit Bot]

Comment on attachment 310922 [details]
Patch, add this SPI for both iOS and macOS.

Clearing flags on attachment: 310922

Committed r217252: <http://trac.webkit.org/changeset/217252>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.