Bug 172449 – [Win] Increase test timeout for slow tests.

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Per Arne Vollan]

There are a number of tests which are finishing just around the timeout limit. We can increase the timeout to make sure these tests will not time out.


06:31:10.330 7616 10 slowest tests that are not marked as SLOW and did not timeout/crash:
06:31:10.330 7616   imported/w3c/web-platform-tests/html/browsers/browsing-the-web/unloading-documents/004.html took 29.3 seconds
06:31:10.330 7616   imported/w3c/web-platform-tests/background-fetch/interfaces.worker.html took 29.1 seconds
06:31:10.330 7616   imported/w3c/web-platform-tests/html/browsers/browsing-the-web/unloading-documents/unload/006.html took 29.1 seconds
06:31:10.330 7616   imported/w3c/web-platform-tests/html/browsers/history/the-history-interface/joint_session_history/001.html took 29.1 seconds
06:31:10.330 7616   imported/w3c/web-platform-tests/html/semantics/forms/textfieldselection/selection-start-end.html took 29.1 seconds
06:31:10.330 7616   imported/w3c/web-platform-tests/html/webappapis/scripting/processing-model-2/compile-error-cross-origin-setInterval.html took 29.1 seconds
06:31:10.330 7616   imported/w3c/web-platform-tests/FileAPI/url/origin.sub.html took 29.1 seconds
06:31:10.330 7616   imported/w3c/web-platform-tests/html/semantics/document-metadata/the-meta-element/pragma-directives/attr-meta-http-equiv-refresh/parsing.html took 29.0 seconds
06:31:10.330 7616   imported/w3c/web-platform-tests/html/dom/documents/dom-tree-accessors/Document.currentScript.html took 29.0 seconds
06:31:10.330 7616   imported/w3c/web-platform-tests/html/semantics/forms/textfieldselection/textfieldselection-setSelectionRange.html took 29.0 seconds

[Per Arne Vollan]

Created attachment 310870 [details]
Patch

[Alexey Proskuryakov]

Comment on attachment 310870 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=310870&action=review

> Tools/ChangeLog:8
> +        There are a number of tests which are finishing just around the timeout limit.

What makes these tests so incredibly slow?

[Build Bot]

Comment on attachment 310870 [details]
Patch

Attachment 310870 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/3794555

New failing tests:
imported/w3c/web-platform-tests/media-source/mediasource-buffered.html

[Build Bot]

Created attachment 310885 [details]
Archive of layout-test-results from ews112 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews112  Port: mac-elcapitan  Platform: Mac OS X 10.11.6

[Per Arne Vollan]

(In reply to Alexey Proskuryakov from comment #2)
> Comment on attachment 310870 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=310870&action=review
> 
> > Tools/ChangeLog:8
> > +        There are a number of tests which are finishing just around the timeout limit.
> 
> What makes these tests so incredibly slow?

I also tested imported/w3c/web-platform-tests/html/browsers/browsing-the-web/unloading-documents/004.html on Mac (debug), and it seems to take almost 30 seconds to finish.

[Per Arne Vollan]

It might be better to mark these tests as slow instead of increasing the test timeout.

[Per Arne Vollan]

Created attachment 310981 [details]
Patch

[Alexey Proskuryakov]

I'm still not sure if all these tests are so slow legitimately. Having tests that take 30 seconds is very costly, so we should consider deleting them unless they are exceptionally important.

[Per Arne Vollan]

(In reply to Alexey Proskuryakov from comment #8)
> I'm still not sure if all these tests are so slow legitimately. Having tests
> that take 30 seconds is very costly, so we should consider deleting them
> unless they are exceptionally important.

Also, there might be a few more slow tests, since the script only displays the 10 slowest.

Thanks for reviewing!

[WebKit Commit Bot]

Comment on attachment 310981 [details]
Patch

Clearing flags on attachment: 310981

Committed r217321: <http://trac.webkit.org/changeset/217321>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/32479821>