Bug 172448 - [ThreadedCompositor] Improve composition and update state handling
Summary: [ThreadedCompositor] Improve composition and update state handling
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Zan Dobersek
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-05-22 07:32 PDT by Zan Dobersek
Modified: 2017-08-14 03:24 PDT (History)
4 users (show)

See Also:

Attachments
WIP (12.99 KB, patch)
2017-05-22 07:33 PDT, Zan Dobersek 		no flags Details | Formatted Diff | Diff
WIP (16.55 KB, patch)
2017-08-09 03:08 PDT, Zan Dobersek 		no flags Details | Formatted Diff | Diff
Patch (21.46 KB, patch)
2017-08-11 04:39 PDT, Zan Dobersek 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Zan Dobersek 2017-05-22 07:32:41 PDT 
[ThreadedCompositor] Improve composition and update state handling
Comment 1 Zan Dobersek 2017-05-22 07:33:30 PDT 
Created attachment 310868 [details]
WIP
Comment 2 Zan Dobersek 2017-08-09 03:08:38 PDT 
Created attachment 317691 [details]
WIP

Needs comments, ChangeLog.
Comment 3 Zan Dobersek 2017-08-11 04:39:23 PDT 
Created attachment 317924 [details]
Patch
Comment 4 Build Bot 2017-08-11 04:41:30 PDT 
Attachment 317924 [details] did not pass style-queue:


ERROR: Source/WebKit/Shared/CoordinatedGraphics/threadedcompositor/ThreadedCompositor.cpp:362:  This { should be at the end of the previous line  [whitespace/braces] [4]
Total errors found: 1 in 6 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 5 Carlos Garcia Campos 2017-08-13 23:42:54 PDT 
Comment on attachment 317924 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=317924&action=review

Excellent comments, it's a lot easier to follow now. Thanks!

> Source/WebKit/Shared/CoordinatedGraphics/threadedcompositor/CompositingRunLoop.cpp:186
> +void CompositingRunLoop::compositionCompleted(LockHolder& stateLocker)

Why does this receive the lock if it's unused, is it just to make sure the caller always calls this with the lock held?
Comment 6 Zan Dobersek 2017-08-14 03:22:38 PDT 
(In reply to Carlos Garcia Campos from comment #5)
> > Source/WebKit/Shared/CoordinatedGraphics/threadedcompositor/CompositingRunLoop.cpp:186
> > +void CompositingRunLoop::compositionCompleted(LockHolder& stateLocker)
> 
> Why does this receive the lock if it's unused, is it just to make sure the
> caller always calls this with the lock held?

Yes, that's the reason.
Comment 7 Zan Dobersek 2017-08-14 03:23:38 PDT 
Comment on attachment 317924 [details]
Patch

Clearing flags on attachment: 317924

Committed r220672: <http://trac.webkit.org/changeset/220672>
Comment 8 Zan Dobersek 2017-08-14 03:23:45 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 9 Radar WebKit Bug Importer 2017-08-14 03:24:10 PDT 
<rdar://problem/33873222>