RESOLVED FIXED172448
[ThreadedCompositor] Improve composition and update state handling 
https://bugs.webkit.org/show_bug.cgi?id=172448
Summary [ThreadedCompositor] Improve composition and update state handling
Zan Dobersek
Reported 2017-05-22 07:32:41 PDT
[ThreadedCompositor] Improve composition and update state handling
Attachments
WIP (12.99 KB, patch)
2017-05-22 07:33 PDT, Zan Dobersek 		no flags
DetailsFormatted DiffDiff
WIP (16.55 KB, patch)
2017-08-09 03:08 PDT, Zan Dobersek 		no flags
DetailsFormatted DiffDiff
Patch (21.46 KB, patch)
2017-08-11 04:39 PDT, Zan Dobersek 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Zan Dobersek
Comment 1 2017-05-22 07:33:30 PDT
Created attachment 310868 [details] WIP
Zan Dobersek
Comment 2 2017-08-09 03:08:38 PDT
Created attachment 317691 [details] WIP Needs comments, ChangeLog.
Zan Dobersek
Comment 3 2017-08-11 04:39:23 PDT
Created attachment 317924 [details] Patch
Build Bot
Comment 4 2017-08-11 04:41:30 PDT
Attachment 317924 [details] did not pass style-queue: ERROR: Source/WebKit/Shared/CoordinatedGraphics/threadedcompositor/ThreadedCompositor.cpp:362: This { should be at the end of the previous line [whitespace/braces] [4] Total errors found: 1 in 6 files If any of these errors are false positives, please file a bug against check-webkit-style.
Carlos Garcia Campos
Comment 5 2017-08-13 23:42:54 PDT
Comment on attachment 317924 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=317924&action=review Excellent comments, it's a lot easier to follow now. Thanks! > Source/WebKit/Shared/CoordinatedGraphics/threadedcompositor/CompositingRunLoop.cpp:186 > +void CompositingRunLoop::compositionCompleted(LockHolder& stateLocker) Why does this receive the lock if it's unused, is it just to make sure the caller always calls this with the lock held?
Zan Dobersek
Comment 6 2017-08-14 03:22:38 PDT
(In reply to Carlos Garcia Campos from comment #5) > > Source/WebKit/Shared/CoordinatedGraphics/threadedcompositor/CompositingRunLoop.cpp:186 > > +void CompositingRunLoop::compositionCompleted(LockHolder& stateLocker) > > Why does this receive the lock if it's unused, is it just to make sure the > caller always calls this with the lock held? Yes, that's the reason.
Zan Dobersek
Comment 7 2017-08-14 03:23:38 PDT
Comment on attachment 317924 [details] Patch Clearing flags on attachment: 317924 Committed r220672: <http://trac.webkit.org/changeset/220672>
Zan Dobersek
Comment 8 2017-08-14 03:23:45 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 9 2017-08-14 03:24:10 PDT
<rdar://problem/33873222>
Note You need to log in before you can comment on or make changes to this bug.