Bug 172447 - [Modern Media Controls] Turn off all tests
Summary: [Modern Media Controls] Turn off all tests
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Antoine Quint
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-05-22 07:32 PDT by Antoine Quint
Modified: 2018-02-05 08:26 PST (History)
4 users (show)

See Also:


Attachments
Patch (18.13 KB, patch)
2017-05-22 07:33 PDT, Antoine Quint
no flags Details | Formatted Diff | Diff
Patch for landing (18.16 KB, patch)
2017-05-23 06:20 PDT, Antoine Quint
no flags Details | Formatted Diff | Diff
Patch for landing (18.97 KB, patch)
2017-05-23 07:02 PDT, Antoine Quint
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Antoine Quint 2017-05-22 07:32:06 PDT
Due to the high number of timeouts and random failures with the current tests, we turn off all modern-media-controls tests while we wait on a more permanent solution.
Comment 1 Radar WebKit Bug Importer 2017-05-22 07:32:25 PDT
<rdar://problem/32325772>
Comment 2 Antoine Quint 2017-05-22 07:33:14 PDT
Created attachment 310867 [details]
Patch
Comment 3 Antoine Quint 2017-05-23 06:20:27 PDT
Created attachment 311002 [details]
Patch for landing
Comment 4 WebKit Commit Bot 2017-05-23 06:58:43 PDT
Comment on attachment 311002 [details]
Patch for landing

Rejecting attachment 311002 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-03', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 311002, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Last 500 characters of output:
ster/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc ...
Currently at 217272 = a266d030e8388ce0dcb658b42aaf952012f0bbab
r217273 = 8e999b93e03c3500417106bde312d216801030b7
Done rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc
First, rewinding head to replay your work on top of it...
Fast-forwarded master to refs/remotes/origin/master.
ERROR: LayoutTests/TestExpectations:1281:  Path does not exist.  [test/expectations] [5]
Total errors found: 1 in 1 files

Full output: http://webkit-queues.webkit.org/results/3800384
Comment 5 Antoine Quint 2017-05-23 07:02:59 PDT
Created attachment 311007 [details]
Patch for landing
Comment 6 WebKit Commit Bot 2017-05-23 07:18:58 PDT
Comment on attachment 311007 [details]
Patch for landing

Clearing flags on attachment: 311007

Committed r217275: <http://trac.webkit.org/changeset/217275>
Comment 7 WebKit Commit Bot 2017-05-23 07:18:59 PDT
All reviewed patches have been landed.  Closing bug.
Comment 8 Jonathan Bedard 2018-01-29 09:42:02 PST
Where are we tracking the work for the 'more permanent solution'?  We shouldn't just keep these tests disabled, especially because at this point, they are only partially disabled.  Many modern-media-controls tests are enabled.
Comment 9 Antoine Quint 2018-01-29 11:45:16 PST
A big underlying problem has been identified and fixed a while back, I'm hoping to turn more tests back on this week, if not all of them.
Comment 10 Antoine Quint 2018-02-05 08:26:36 PST
These are being turned back on with https://bugs.webkit.org/show_bug.cgi?id=182482.