Bug 172443 – Avoid looping infinitely when calling innerText on display: contents nodes under certain conditions.

• Status: RESOLVED
• Resolution: FIXED
• Component: CSS

[Emilio Cobos Álvarez]

This is a bug that enabling display: contents on bug 171984 exposes, and will be exercised in imported/w3c/web-platform-tests/innerText/getter.html once it lands.

[Emilio Cobos Álvarez]

Created attachment 310852 [details]
Patch

[Build Bot]

Comment on attachment 310852 [details]
Patch

Attachment 310852 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/3793926

Number of test failures exceeded the failure limit.

[Build Bot]

Created attachment 310855 [details]
Archive of layout-test-results from ews101 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews101  Port: mac-elcapitan  Platform: Mac OS X 10.11.6

[Build Bot]

Comment on attachment 310852 [details]
Patch

Attachment 310852 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/3793928

Number of test failures exceeded the failure limit.

[Build Bot]

Created attachment 310857 [details]
Archive of layout-test-results from ews105 for mac-elcapitan-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews105  Port: mac-elcapitan-wk2  Platform: Mac OS X 10.11.6

[Build Bot]

Comment on attachment 310852 [details]
Patch

Attachment 310852 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/3793920

Number of test failures exceeded the failure limit.

[Build Bot]

Created attachment 310858 [details]
Archive of layout-test-results from ews112 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews112  Port: mac-elcapitan  Platform: Mac OS X 10.11.6

[Emilio Cobos Álvarez]

Was too easy, of course... looking at the failures, will try to come up with a fix that doesn't break the world.

[Build Bot]

Comment on attachment 310852 [details]
Patch

Attachment 310852 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/3794008

New failing tests:
fast/forms/input-text-paste-maxlength.html
fast/forms/input-text-maxlength.html
accessibility/ios-simulator/speak-selection-content.html
fast/forms/textarea-maxlength.html
editing/text-iterator/count-matches-in-form.html
editing/text-iterator/find-string-on-flat-tree.html
fast/forms/number/number-validity-badinput.html
fast/forms/input-value-sanitization.html

[Build Bot]

Created attachment 310861 [details]
Archive of layout-test-results from ews124 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews124  Port: ios-simulator-wk2  Platform: Mac OS X 10.11.6

[Emilio Cobos Álvarez]

Created attachment 310871 [details]
Patch

[Build Bot]

Comment on attachment 310871 [details]
Patch

Attachment 310871 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/3794460

Number of test failures exceeded the failure limit.

[Build Bot]

Created attachment 310876 [details]
Archive of layout-test-results from ews116 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews116  Port: mac-elcapitan  Platform: Mac OS X 10.11.6

[Build Bot]

Comment on attachment 310871 [details]
Patch

Attachment 310871 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/3794500

Number of test failures exceeded the failure limit.

[Build Bot]

Created attachment 310877 [details]
Archive of layout-test-results from ews101 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews101  Port: mac-elcapitan  Platform: Mac OS X 10.11.6

[Build Bot]

Comment on attachment 310871 [details]
Patch

Attachment 310871 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/3794501

Number of test failures exceeded the failure limit.

[Build Bot]

Created attachment 310879 [details]
Archive of layout-test-results from ews105 for mac-elcapitan-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews105  Port: mac-elcapitan-wk2  Platform: Mac OS X 10.11.6

[Build Bot]

Comment on attachment 310871 [details]
Patch

Attachment 310871 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/3794532

New failing tests:
fast/forms/input-text-paste-maxlength.html
fast/forms/input-text-maxlength.html
accessibility/ios-simulator/speak-selection-content.html
fast/forms/textarea-maxlength.html
editing/text-iterator/count-matches-in-form.html
editing/text-iterator/find-string-on-flat-tree.html
fast/forms/number/number-validity-badinput.html
fast/forms/input-value-sanitization.html

[Build Bot]

Created attachment 310883 [details]
Archive of layout-test-results from ews121 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews121  Port: ios-simulator-wk2  Platform: Mac OS X 10.11.6

[Emilio Cobos Álvarez]

Created attachment 310891 [details]
Patch

[Emilio Cobos Álvarez]

Comment on attachment 310891 [details]
Patch

Yikes, that was a very dumb bug on my initial patch too.

[Antti Koivisto]

Comment on attachment 310891 [details]
Patch

r=me

[WebKit Commit Bot]

Comment on attachment 310891 [details]
Patch

Clearing flags on attachment: 310891

Committed r217238: <http://trac.webkit.org/changeset/217238>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Emilio Cobos Álvarez]

(In reply to Antti Koivisto from comment #22)
> Comment on attachment 310891 [details]
> Patch
> 
> r=me

Thanks for the review Antti :)