Bug 172443 - Avoid looping infinitely when calling innerText on display: contents nodes under certain conditions.
Summary: Avoid looping infinitely when calling innerText on display: contents nodes un...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks: 171984
  Show dependency treegraph
 
Reported: 2017-05-22 05:14 PDT by Emilio Cobos Álvarez
Modified: 2017-05-22 13:46 PDT (History)
5 users (show)

See Also:


Attachments
Patch (2.38 KB, patch)
2017-05-22 05:23 PDT, Emilio Cobos Álvarez
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews101 for mac-elcapitan (279.24 KB, application/zip)
2017-05-22 06:09 PDT, Build Bot
no flags Details
Archive of layout-test-results from ews105 for mac-elcapitan-wk2 (368.91 KB, application/zip)
2017-05-22 06:11 PDT, Build Bot
no flags Details
Archive of layout-test-results from ews112 for mac-elcapitan (266.08 KB, application/zip)
2017-05-22 06:12 PDT, Build Bot
no flags Details
Archive of layout-test-results from ews124 for ios-simulator-wk2 (996.34 KB, application/zip)
2017-05-22 06:55 PDT, Build Bot
no flags Details
Patch (2.39 KB, patch)
2017-05-22 07:39 PDT, Emilio Cobos Álvarez
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews116 for mac-elcapitan (1.16 MB, application/zip)
2017-05-22 08:06 PDT, Build Bot
no flags Details
Archive of layout-test-results from ews101 for mac-elcapitan (615.43 KB, application/zip)
2017-05-22 08:19 PDT, Build Bot
no flags Details
Archive of layout-test-results from ews105 for mac-elcapitan-wk2 (540.77 KB, application/zip)
2017-05-22 08:22 PDT, Build Bot
no flags Details
Archive of layout-test-results from ews121 for ios-simulator-wk2 (1.08 MB, application/zip)
2017-05-22 08:56 PDT, Build Bot
no flags Details
Patch (2.43 KB, patch)
2017-05-22 10:20 PDT, Emilio Cobos Álvarez
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Emilio Cobos Álvarez 2017-05-22 05:14:04 PDT
This is a bug that enabling display: contents on bug 171984 exposes, and will be exercised in imported/w3c/web-platform-tests/innerText/getter.html once it lands.
Comment 1 Emilio Cobos Álvarez 2017-05-22 05:23:06 PDT
Created attachment 310852 [details]
Patch
Comment 2 Build Bot 2017-05-22 06:09:06 PDT
Comment on attachment 310852 [details]
Patch

Attachment 310852 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/3793926

Number of test failures exceeded the failure limit.
Comment 3 Build Bot 2017-05-22 06:09:07 PDT
Created attachment 310855 [details]
Archive of layout-test-results from ews101 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews101  Port: mac-elcapitan  Platform: Mac OS X 10.11.6
Comment 4 Build Bot 2017-05-22 06:11:29 PDT
Comment on attachment 310852 [details]
Patch

Attachment 310852 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/3793928

Number of test failures exceeded the failure limit.
Comment 5 Build Bot 2017-05-22 06:11:30 PDT
Created attachment 310857 [details]
Archive of layout-test-results from ews105 for mac-elcapitan-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews105  Port: mac-elcapitan-wk2  Platform: Mac OS X 10.11.6
Comment 6 Build Bot 2017-05-22 06:12:12 PDT
Comment on attachment 310852 [details]
Patch

Attachment 310852 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/3793920

Number of test failures exceeded the failure limit.
Comment 7 Build Bot 2017-05-22 06:12:13 PDT
Created attachment 310858 [details]
Archive of layout-test-results from ews112 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews112  Port: mac-elcapitan  Platform: Mac OS X 10.11.6
Comment 8 Emilio Cobos Álvarez 2017-05-22 06:23:21 PDT
Was too easy, of course... looking at the failures, will try to come up with a fix that doesn't break the world.
Comment 9 Build Bot 2017-05-22 06:55:16 PDT
Comment on attachment 310852 [details]
Patch

Attachment 310852 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/3794008

New failing tests:
fast/forms/input-text-paste-maxlength.html
fast/forms/input-text-maxlength.html
accessibility/ios-simulator/speak-selection-content.html
fast/forms/textarea-maxlength.html
editing/text-iterator/count-matches-in-form.html
editing/text-iterator/find-string-on-flat-tree.html
fast/forms/number/number-validity-badinput.html
fast/forms/input-value-sanitization.html
Comment 10 Build Bot 2017-05-22 06:55:17 PDT
Created attachment 310861 [details]
Archive of layout-test-results from ews124 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews124  Port: ios-simulator-wk2  Platform: Mac OS X 10.11.6
Comment 11 Emilio Cobos Álvarez 2017-05-22 07:39:26 PDT
Created attachment 310871 [details]
Patch
Comment 12 Build Bot 2017-05-22 08:06:42 PDT
Comment on attachment 310871 [details]
Patch

Attachment 310871 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/3794460

Number of test failures exceeded the failure limit.
Comment 13 Build Bot 2017-05-22 08:06:45 PDT
Created attachment 310876 [details]
Archive of layout-test-results from ews116 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews116  Port: mac-elcapitan  Platform: Mac OS X 10.11.6
Comment 14 Build Bot 2017-05-22 08:19:04 PDT
Comment on attachment 310871 [details]
Patch

Attachment 310871 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/3794500

Number of test failures exceeded the failure limit.
Comment 15 Build Bot 2017-05-22 08:19:05 PDT
Created attachment 310877 [details]
Archive of layout-test-results from ews101 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews101  Port: mac-elcapitan  Platform: Mac OS X 10.11.6
Comment 16 Build Bot 2017-05-22 08:22:04 PDT
Comment on attachment 310871 [details]
Patch

Attachment 310871 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/3794501

Number of test failures exceeded the failure limit.
Comment 17 Build Bot 2017-05-22 08:22:05 PDT
Created attachment 310879 [details]
Archive of layout-test-results from ews105 for mac-elcapitan-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews105  Port: mac-elcapitan-wk2  Platform: Mac OS X 10.11.6
Comment 18 Build Bot 2017-05-22 08:56:33 PDT
Comment on attachment 310871 [details]
Patch

Attachment 310871 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/3794532

New failing tests:
fast/forms/input-text-paste-maxlength.html
fast/forms/input-text-maxlength.html
accessibility/ios-simulator/speak-selection-content.html
fast/forms/textarea-maxlength.html
editing/text-iterator/count-matches-in-form.html
editing/text-iterator/find-string-on-flat-tree.html
fast/forms/number/number-validity-badinput.html
fast/forms/input-value-sanitization.html
Comment 19 Build Bot 2017-05-22 08:56:34 PDT
Created attachment 310883 [details]
Archive of layout-test-results from ews121 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews121  Port: ios-simulator-wk2  Platform: Mac OS X 10.11.6
Comment 20 Emilio Cobos Álvarez 2017-05-22 10:20:13 PDT
Created attachment 310891 [details]
Patch
Comment 21 Emilio Cobos Álvarez 2017-05-22 11:17:10 PDT
Comment on attachment 310891 [details]
Patch

Yikes, that was a very dumb bug on my initial patch too.
Comment 22 Antti Koivisto 2017-05-22 12:23:57 PDT
Comment on attachment 310891 [details]
Patch

r=me
Comment 23 WebKit Commit Bot 2017-05-22 12:43:43 PDT
Comment on attachment 310891 [details]
Patch

Clearing flags on attachment: 310891

Committed r217238: <http://trac.webkit.org/changeset/217238>
Comment 24 WebKit Commit Bot 2017-05-22 12:43:45 PDT
All reviewed patches have been landed.  Closing bug.
Comment 25 Emilio Cobos Álvarez 2017-05-22 13:46:48 PDT
(In reply to Antti Koivisto from comment #22)
> Comment on attachment 310891 [details]
> Patch
> 
> r=me

Thanks for the review Antti :)