WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
172433
Do no enter Subversion-specific logic when parsing Git-based Trac data.
https://bugs.webkit.org/show_bug.cgi?id=172433
Summary
Do no enter Subversion-specific logic when parsing Git-based Trac data.
Jason Marcell
Reported
2017-05-21 17:46:45 PDT
Do no enter Subversion-specific logic when parsing Git-based Trac data.
Attachments
Patch
(2.45 KB, patch)
2017-05-21 17:47 PDT
,
Jason Marcell
no flags
Details
Formatted Diff
Diff
Patch
(2.49 KB, patch)
2017-05-21 17:49 PDT
,
Jason Marcell
ap
: review+
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
Jason Marcell
Comment 1
2017-05-21 17:47:52 PDT
Created
attachment 310822
[details]
Patch
Jason Marcell
Comment 2
2017-05-21 17:49:49 PDT
Created
attachment 310823
[details]
Patch
Alexey Proskuryakov
Comment 3
2017-05-21 18:20:43 PDT
Comment on
attachment 310823
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=310823&action=review
> Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Trac.js:182 > + // Note: we have an overidden timeline.rss that adds git branches to the Trac timeline RSS output (
rdar://problem/23853623
)
I suggest removing "Note:", as every comment is a note. Please also add a period in the end to make it a proper sentence.
Kocsen Chung
Comment 4
2017-05-22 09:34:31 PDT
👍, thanks Jason.
Jason Marcell
Comment 5
2017-05-22 17:32:14 PDT
Committed
r217259
to
https://svn.webkit.org/repository/webkit/trunk
.
https://trac.webkit.org/r217259
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug