Bug 172433 - Do no enter Subversion-specific logic when parsing Git-based Trac data.
Summary: Do no enter Subversion-specific logic when parsing Git-based Trac data.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-05-21 17:46 PDT by Jason Marcell
Modified: 2017-05-22 17:32 PDT (History)
2 users (show)

See Also:

Attachments
Patch (2.45 KB, patch)
2017-05-21 17:47 PDT, Jason Marcell 		no flags Details | Formatted Diff | Diff
Patch (2.49 KB, patch)
2017-05-21 17:49 PDT, Jason Marcell 		ap: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jason Marcell 2017-05-21 17:46:45 PDT 
Do no enter Subversion-specific logic when parsing Git-based Trac data.
Comment 1 Jason Marcell 2017-05-21 17:47:52 PDT 
Created attachment 310822 [details]
Patch
Comment 2 Jason Marcell 2017-05-21 17:49:49 PDT 
Created attachment 310823 [details]
Patch
Comment 3 Alexey Proskuryakov 2017-05-21 18:20:43 PDT 
Comment on attachment 310823 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=310823&action=review

> Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Trac.js:182
> +        // Note: we have an overidden timeline.rss that adds git branches to the Trac timeline RSS output (rdar://problem/23853623)

I suggest removing "Note:", as every comment is a note. Please also add a period in the end to make it a proper sentence.
Comment 4 Kocsen Chung 2017-05-22 09:34:31 PDT 
👍, thanks Jason.