Bug 172432 – Web Inspector: Using "break on all exceptions" when throwing stack overflow hangs inspector

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector

[Saam Barati]

e.g, if I enable "Break on all exceptions" and run this program, web inspector hangs for me. My guess is it's trying to do stuff above the JS stack at the time of stack overflow, which if true, is definitely not allowed.

```
let arg = 20
function f() {
    f(arg);
}

function recurse() {
    try {
        f();
    } catch(e) {
    }
    setTimeout(recurse, 0);
}
recurse();
```

[Matt Baker]

<rdar://problem/29870873>

[Joseph Pecoraro]

Created attachment 313459 [details]
[PATCH] Proposed Fix v4

[Saam Barati]

Comment on attachment 313459 [details]
[PATCH] Proposed Fix v4

r=me
Can you add a test that ensures we don't catch it in inspector?

[Joseph Pecoraro]

Comment on attachment 313459 [details]
[PATCH] Proposed Fix v4

Oops, yes I totally meant to add a test.

[Joseph Pecoraro]

Created attachment 313546 [details]
[PATCH] Proposed Fix - With Tests

[Joseph Pecoraro]

Comment on attachment 313546 [details]
[PATCH] Proposed Fix - With Tests

View in context: https://bugs.webkit.org/attachment.cgi?id=313546&action=review

> LayoutTests/inspector/debugger/no-pause-stack-overflow-exception.html:21
> +    WebInspector.debuggerManager.assertionsBreakpoint.disabled = false;

I can drop the assertions breakpoint. I really just need the all exceptions one.

[Joseph Pecoraro]

Created attachment 313547 [details]
[PATCH] Proposed Fix - With Tests

[WebKit Commit Bot]

Comment on attachment 313547 [details]
[PATCH] Proposed Fix - With Tests

Clearing flags on attachment: 313547

Committed r218652: <http://trac.webkit.org/changeset/218652>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.