In the past, many tests were being split into HTML and JS parts for no good reason. This makes it hard to see what those tests are doing.
Created attachment 310784 [details] patch for EWS
Created attachment 310794 [details] patch for EWS
Created attachment 310821 [details] patch for EWS
Comment on attachment 310821 [details] patch for EWS Attachment 310821 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/3791451 New failing tests: fast/regex/dom/cross-frame-callable.html fast/parser/double-write-from-closed-iframe.html fast/dom/Geolocation/notimer-after-unload.html fast/dom/Window/invalid-protocol.html fast/dom/dataset-xhtml.xhtml fast/dom/javascript-url-exception-isolation.html svg/custom/poly-parsing-error.html fast/text/find-russian.html fast/dom/webtiming-document-open.html svg/dom/path-parser.html fast/dom/Geolocation/callback-exception.html fast/dom/HTMLScriptElement/script-for-attribute-unexpected-execution.html fast/dom/Geolocation/clear-watch-invalid-id-crash.html fast/parser/fragment-parser.html
Created attachment 310824 [details] Archive of layout-test-results from ews101 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews101 Port: mac-elcapitan Platform: Mac OS X 10.11.6
Created attachment 310825 [details] Archive of layout-test-results from ews104 for mac-elcapitan-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews104 Port: mac-elcapitan-wk2 Platform: Mac OS X 10.11.6
Comment on attachment 310821 [details] patch for EWS Attachment 310821 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/3791455 New failing tests: fast/dom/Window/invalid-protocol.html fast/parser/double-write-from-closed-iframe.html fast/dom/Geolocation/notimer-after-unload.html fast/dom/dataset-xhtml.xhtml fast/dom/javascript-url-exception-isolation.html svg/custom/poly-parsing-error.html fast/text/find-russian.html fast/regex/dom/cross-frame-callable.html fast/dom/webtiming-document-open.html svg/dom/path-parser.html fast/dom/Geolocation/callback-exception.html fast/dom/HTMLScriptElement/script-for-attribute-unexpected-execution.html fast/dom/Geolocation/clear-watch-invalid-id-crash.html fast/parser/fragment-parser.html
Created attachment 310826 [details] Archive of layout-test-results from ews115 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews115 Port: mac-elcapitan Platform: Mac OS X 10.11.6
Comment on attachment 310821 [details] patch for EWS Attachment 310821 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/3791479 New failing tests: fast/dom/Window/invalid-protocol.html fast/parser/double-write-from-closed-iframe.html fast/dom/Geolocation/notimer-after-unload.html fast/scrolling/ios/overflow-div-scrolling.html fast/dom/dataset-xhtml.xhtml fast/dom/javascript-url-exception-isolation.html svg/custom/poly-parsing-error.html fast/text/find-russian.html fast/regex/dom/cross-frame-callable.html fast/dom/webtiming-document-open.html svg/dom/path-parser.html fast/dom/HTMLScriptElement/script-for-attribute-unexpected-execution.html fast/dom/Geolocation/clear-watch-invalid-id-crash.html fast/parser/fragment-parser.html
Created attachment 310827 [details] Archive of layout-test-results from ews122 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews122 Port: ios-simulator-wk2 Platform: Mac OS X 10.11.6
Comment on attachment 310821 [details] patch for EWS Attachment 310821 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/3791848 New failing tests: fast/dom/HTMLScriptElement/script-for-attribute-unexpected-execution.html fast/dom/Window/invalid-protocol.html fast/parser/double-write-from-closed-iframe.html fast/dom/Geolocation/notimer-after-unload.html fast/dom/dataset-xhtml.xhtml fast/dom/javascript-url-exception-isolation.html svg/custom/poly-parsing-error.html fast/text/find-russian.html fast/regex/dom/cross-frame-callable.html fast/dom/webtiming-document-open.html svg/dom/path-parser.html fast/scrolling/ios/overflow-div-scrolling.html fast/dom/Geolocation/clear-watch-invalid-id-crash.html fast/parser/fragment-parser.html
Created attachment 310830 [details] Archive of layout-test-results from ews124 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews124 Port: ios-simulator-wk2 Platform: Mac OS X 10.11.6
Created attachment 310900 [details] proposed patch
Created attachment 311104 [details] proposed patch
Created attachment 311105 [details] proposed patch
Comment on attachment 311105 [details] proposed patch Very nice!
Comment on attachment 311105 [details] proposed patch Clearing flags on attachment: 311105 Committed r217390: <http://trac.webkit.org/changeset/217390>
All reviewed patches have been landed. Closing bug.
Re-opening for part 2.
Created attachment 311204 [details] part 2
(In reply to WebKit Commit Bot from comment #17) > Comment on attachment 311105 [details] > proposed patch > > Clearing flags on attachment: 311105 > > Committed r217390: <http://trac.webkit.org/changeset/217390> This broken internal Production builds that had a build step that called Tools/Scripts/run-jsc-stress-tests, which read LayoutTests/jsc-layout-tests.yaml, which references fast/regex/script-tests.
Comment on attachment 311204 [details] part 2 Attachment 311204 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/3811321 New failing tests: fetch/closing-while-fetching-blob.html
Created attachment 311208 [details] Archive of layout-test-results from ews125 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews125 Port: ios-simulator-wk2 Platform: Mac OS X 10.12.5
(In reply to David Kilzer (:ddkilzer) from comment #21) > (In reply to WebKit Commit Bot from comment #17) > > Comment on attachment 311105 [details] > > proposed patch > > > > Clearing flags on attachment: 311105 > > > > Committed r217390: <http://trac.webkit.org/changeset/217390> > > This broken internal Production builds that had a build step that called > Tools/Scripts/run-jsc-stress-tests, which read > LayoutTests/jsc-layout-tests.yaml, which references fast/regex/script-tests. I rolled out changes to LayoutTests/fast/regex/ from r217390 here: Bug 172584: REGRESSION(r217390): "Broke internal Production builds that ran run-jsc-stress-tests" (Requested by ddkilzer on #webkit). <https://bugs.webkit.org/show_bug.cgi?id=172584> <http://trac.webkit.org/changeset/217408>
(In reply to David Kilzer (:ddkilzer) from comment #21) > (In reply to WebKit Commit Bot from comment #17) > > Comment on attachment 311105 [details] > > proposed patch > > > > Clearing flags on attachment: 311105 > > > > Committed r217390: <http://trac.webkit.org/changeset/217390> > > This broken internal Production builds that had a build step that called > Tools/Scripts/run-jsc-stress-tests, which read > LayoutTests/jsc-layout-tests.yaml, which references fast/regex/script-tests. Not only the internal tests, but all JSC bots on build.webkit.org waterfall.
Thanks! I didn't touch js and imported, but had no idea that fast/regex was also special. It should probably be moved inside js then.
Comment on attachment 311204 [details] part 2 rs=me
Comment on attachment 311204 [details] part 2 Clearing flags on attachment: 311204 Committed r217466: <http://trac.webkit.org/changeset/217466>
<rdar://problem/32479864>