Bug 172417 - [JSC] Drop MapBase
Summary: [JSC] Drop MapBase
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Yusuke Suzuki
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-05-20 11:23 PDT by Yusuke Suzuki
Modified: 2017-05-20 15:23 PDT (History)
3 users (show)

See Also:

Attachments
Patch (28.24 KB, patch)
2017-05-20 11:25 PDT, Yusuke Suzuki 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Yusuke Suzuki 2017-05-20 11:23:32 PDT 
[JSC] Drop MapBase
Comment 1 Yusuke Suzuki 2017-05-20 11:25:13 PDT 
Created attachment 310776 [details]
Patch
Comment 2 Sam Weinig 2017-05-20 11:54:28 PDT 
Comment on attachment 310776 [details]
Patch

Very nice. Any idea why the indirection was there in the first place? Was this from a time when the HashMap wasn't a JSCell?
Comment 3 Yusuke Suzuki 2017-05-20 12:38:14 PDT 
Comment on attachment 310776 [details]
Patch

Discussed with Saam at IRC (private message). We guess that this is accidentally introduced.
Comment 4 WebKit Commit Bot 2017-05-20 13:07:26 PDT 
Comment on attachment 310776 [details]
Patch

Clearing flags on attachment: 310776

Committed r217192: <http://trac.webkit.org/changeset/217192>
Comment 5 WebKit Commit Bot 2017-05-20 13:07:27 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 6 Saam Barati 2017-05-20 15:23:08 PDT 
(In reply to Sam Weinig from comment #2)
> Comment on attachment 310776 [details]
> Patch
> 
> Very nice. Any idea why the indirection was there in the first place? Was
> this from a time when the HashMap wasn't a JSCell?

There isn’t a goood reason. When I rewrote our map/set implementation last year I just left this in.