WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
172398
Many WebAudio js-tests use waitUntilDone
https://bugs.webkit.org/show_bug.cgi?id=172398
Summary
Many WebAudio js-tests use waitUntilDone
Alexey Proskuryakov
Reported
2017-05-19 16:10:26 PDT
js-tests are incompatible with testRunner.waitUntilDone(), yet there are hundreds of tests that mix these techniques. The common symptom is that TEST COMPLETE is printed before the test is complete. But there may be more, including flakiness. Some of these tests are malformed in other ways, such as using js-test-pre.js without js-test-post.js.
Attachments
proposed patch
(76.95 KB, patch)
2017-05-19 16:12 PDT
,
Alexey Proskuryakov
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Alexey Proskuryakov
Comment 1
2017-05-19 16:12:59 PDT
Created
attachment 310720
[details]
proposed patch
Sam Weinig
Comment 2
2017-05-19 16:32:23 PDT
Comment on
attachment 310720
[details]
proposed patch rs=me
WebKit Commit Bot
Comment 3
2017-05-22 13:49:16 PDT
Comment on
attachment 310720
[details]
proposed patch Clearing flags on attachment: 310720 Committed
r217243
: <
http://trac.webkit.org/changeset/217243
>
WebKit Commit Bot
Comment 4
2017-05-22 13:49:17 PDT
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug