Bug 172398 - Many WebAudio js-tests use waitUntilDone
Summary: Many WebAudio js-tests use waitUntilDone
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: Safari 9
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alexey Proskuryakov
Depends on:
Blocks: 168961
  Show dependency treegraph
Reported: 2017-05-19 16:10 PDT by Alexey Proskuryakov
Modified: 2017-05-22 13:49 PDT (History)
5 users (show)

See Also:

proposed patch (76.95 KB, patch)
2017-05-19 16:12 PDT, Alexey Proskuryakov
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alexey Proskuryakov 2017-05-19 16:10:26 PDT
js-tests are incompatible with testRunner.waitUntilDone(), yet there are hundreds of tests that mix these techniques.

The common symptom is that TEST COMPLETE is printed before the test is complete. But there may be more, including flakiness. Some of these tests are malformed in other ways, such as using js-test-pre.js without js-test-post.js.
Comment 1 Alexey Proskuryakov 2017-05-19 16:12:59 PDT
Created attachment 310720 [details]
proposed patch
Comment 2 Sam Weinig 2017-05-19 16:32:23 PDT
Comment on attachment 310720 [details]
proposed patch

Comment 3 WebKit Commit Bot 2017-05-22 13:49:16 PDT
Comment on attachment 310720 [details]
proposed patch

Clearing flags on attachment: 310720

Committed r217243: <http://trac.webkit.org/changeset/217243>
Comment 4 WebKit Commit Bot 2017-05-22 13:49:17 PDT
All reviewed patches have been landed.  Closing bug.