Bug 172396 - Implement additional AVPlayerController interfaces for minTime and maxTime.
Summary: Implement additional AVPlayerController interfaces for minTime and maxTime.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: WebKit Nightly Build
Hardware: iPhone / iPad Unspecified
: P2 Normal
Assignee: Jeremy Jones
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-05-19 15:39 PDT by Jeremy Jones
Modified: 2017-06-08 14:47 PDT (History)
5 users (show)

See Also:

Attachments
Preliminary Patch. (45.94 KB, patch)
2017-05-19 17:21 PDT, Jeremy Jones 		no flags Details | Formatted Diff | Diff
Patch (49.80 KB, patch)
2017-06-06 20:36 PDT, Jeremy Jones 		no flags Details | Formatted Diff | Diff
Patch (50.11 KB, patch)
2017-06-07 12:45 PDT, Jeremy Jones 		no flags Details | Formatted Diff | Diff
Patch (53.44 KB, patch)
2017-06-08 12:02 PDT, Jeremy Jones 		no flags Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jeremy Jones 2017-05-19 15:39:34 PDT 
Implement additional AVPlayerController interfaces for minTime and maxTime.
Comment 1 Jeremy Jones 2017-05-19 15:41:02 PDT 
rdar://problem/30737452
Comment 2 Jeremy Jones 2017-05-19 17:21:42 PDT 
Created attachment 310732 [details]
Preliminary Patch.
Comment 3 Build Bot 2017-05-19 17:24:51 PDT 
Attachment 310732 [details] did not pass style-queue:


ERROR: Source/WebCore/platform/spi/mac/AVFoundationSPI.h:54:  Extra space before ( in function call  [whitespace/parens] [4]
Total errors found: 1 in 26 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 4 Jeremy Jones 2017-06-06 20:36:00 PDT 
Created attachment 312160 [details]
Patch
Comment 5 Build Bot 2017-06-06 20:38:15 PDT 
Attachment 312160 [details] did not pass style-queue:


ERROR: Source/WebCore/platform/spi/mac/AVFoundationSPI.h:54:  Extra space before ( in function call  [whitespace/parens] [4]
Total errors found: 1 in 26 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 6 Jeremy Jones 2017-06-07 12:45:48 PDT 
Created attachment 312211 [details]
Patch
Comment 7 Build Bot 2017-06-07 12:48:16 PDT 
Attachment 312211 [details] did not pass style-queue:


ERROR: Source/WebCore/platform/spi/mac/AVFoundationSPI.h:54:  Extra space before ( in function call  [whitespace/parens] [4]
Total errors found: 1 in 26 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 8 Jer Noble 2017-06-08 11:15:44 PDT 
Comment on attachment 312211 [details]
Patch

I think we can re-enable progress events on iOS, then you won't need the timer.
Comment 9 Jeremy Jones 2017-06-08 12:02:30 PDT 
Created attachment 312330 [details]
Patch
Comment 10 WebKit Commit Bot 2017-06-08 14:47:42 PDT 
Comment on attachment 312330 [details]
Patch

Clearing flags on attachment: 312330

Committed r217948: <http://trac.webkit.org/changeset/217948>
Comment 11 WebKit Commit Bot 2017-06-08 14:47:44 PDT 
All reviewed patches have been landed.  Closing bug.