Bug 172379 - Many CSS js-tests use waitUntilDone
Summary: Many CSS js-tests use waitUntilDone
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: Safari 9
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alexey Proskuryakov
URL:
Keywords:
Depends on:
Blocks: 168961
  Show dependency treegraph
 
Reported: 2017-05-19 12:52 PDT by Alexey Proskuryakov
Modified: 2017-05-19 14:19 PDT (History)
5 users (show)

See Also:


Attachments
proposed patch (43.39 KB, patch)
2017-05-19 12:53 PDT, Alexey Proskuryakov
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alexey Proskuryakov 2017-05-19 12:52:10 PDT
js-tests are incompatible with testRunner.waitUntilDone(), yet there are hundreds of tests that mix these techniques.

The common symptom is that TEST COMPLETE is printed before the test is complete. But there may be more, including flakiness. Some of these tests are malformed in other ways, such as using js-test-pre.js without js-test-post.js.
Comment 1 Alexey Proskuryakov 2017-05-19 12:53:50 PDT
Created attachment 310686 [details]
proposed patch
Comment 2 Tim Horton 2017-05-19 13:41:45 PDT
Comment on attachment 310686 [details]
proposed patch

rs=me
Comment 3 WebKit Commit Bot 2017-05-19 14:19:03 PDT
Comment on attachment 310686 [details]
proposed patch

Clearing flags on attachment: 310686

Committed r217150: <http://trac.webkit.org/changeset/217150>
Comment 4 WebKit Commit Bot 2017-05-19 14:19:05 PDT
All reviewed patches have been landed.  Closing bug.