Bug 172375 – Inherit media user gestures from the top document when autoplay quirks are allowed

• Status: RESOLVED
• Resolution: FIXED
• Component: Media

[Matt Rajca]

Inherit media user gesture from document when autoplay quirks are allowed.

[Matt Rajca]

Created attachment 310683 [details]
Patch

[Alex Christensen]

Comment on attachment 310683 [details]
Patch

Can this be tested?

[Matt Rajca]

(In reply to Alex Christensen from comment #2)
> Comment on attachment 310683 [details]
> Patch
> 
> Can this be tested?

We already have a test for 'mediaUserGestureInheritsFromDocument'. Not sure how valuable it is testing: 

    auto* loader = this->loader();
    if (loader && loader->allowsAutoplayQuirks())

[Daniel Bates]

(In reply to Matt Rajca from comment #3)
> (In reply to Alex Christensen from comment #2)
> > Comment on attachment 310683 [details]
> > Patch
> > 
> > Can this be tested?
> 
> We already have a test for 'mediaUserGestureInheritsFromDocument'. Not sure
> how valuable it is testing: 
> 
>     auto* loader = this->loader();
>     if (loader && loader->allowsAutoplayQuirks())

It is valuable to test this code to ensure that we do not regress the behavior of this SPI. In general, every change that has an observable effect should include a test if it is feasible to write one.

[Matt Rajca]

(In reply to Daniel Bates from comment #4)
> (In reply to Matt Rajca from comment #3)
> > (In reply to Alex Christensen from comment #2)
> > > Comment on attachment 310683 [details]
> > > Patch
> > > 
> > > Can this be tested?
> > 
> > We already have a test for 'mediaUserGestureInheritsFromDocument'. Not sure
> > how valuable it is testing: 
> > 
> >     auto* loader = this->loader();
> >     if (loader && loader->allowsAutoplayQuirks())
> 
> It is valuable to test this code to ensure that we do not regress the
> behavior of this SPI. In general, every change that has an observable effect
> should include a test if it is feasible to write one.

OK, will add one.

[Matt Rajca]

Created attachment 310698 [details]
Patch

[Matt Rajca]

Created attachment 310702 [details]
Patch

[Matt Rajca]

r217152