Bug 172372 - Many accessibility js-tests use waitUntilDone
Summary: Many accessibility js-tests use waitUntilDone
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: Safari 9
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alexey Proskuryakov
Depends on:
Blocks: 168961
  Show dependency treegraph
Reported: 2017-05-19 11:57 PDT by Alexey Proskuryakov
Modified: 2017-05-19 23:45 PDT (History)
5 users (show)

See Also:

proposed patch (89.52 KB, patch)
2017-05-19 12:02 PDT, Alexey Proskuryakov
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alexey Proskuryakov 2017-05-19 11:57:16 PDT
js-tests are incompatible with testRunner.waitUntilDone(), yet there are hundreds of tests that mix these techniques.

The common symptom is that TEST COMPLETE is printed before the test is complete. But there may be more, including flakiness. Some of these tests are malformed in other ways, such as using js-test-pre.js without js-test-post.js.
Comment 1 Alexey Proskuryakov 2017-05-19 12:02:16 PDT
Created attachment 310681 [details]
proposed patch
Comment 2 Tim Horton 2017-05-19 13:42:01 PDT
Comment on attachment 310681 [details]
proposed patch

Comment 3 WebKit Commit Bot 2017-05-19 14:19:06 PDT
Comment on attachment 310681 [details]
proposed patch

Rejecting attachment 310681 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-02', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 310681, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Last 500 characters of output:
   dbd4584..7c5c449  master     -> origin/master
Partial-rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc ...
Currently at 217148 = dbd4584443870cc224a699c54c990aee659f7abc
r217149 = 7c5c4496c93dce138fa915f47bf12790ad2b7f22
Done rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc
First, rewinding head to replay your work on top of it...
Fast-forwarded master to refs/remotes/origin/master.

Full output: http://webkit-queues.webkit.org/results/3778831
Comment 4 WebKit Commit Bot 2017-05-19 16:38:03 PDT
Comment on attachment 310681 [details]
proposed patch

Clearing flags on attachment: 310681

Committed r217171: <http://trac.webkit.org/changeset/217171>
Comment 5 WebKit Commit Bot 2017-05-19 16:38:05 PDT
All reviewed patches have been landed.  Closing bug.
Comment 6 Daniel Bates 2017-05-19 22:44:37 PDT
js-test.js is an out-of-date merge of js-test-pre.js and js-test-post.js.
Comment 7 Alexey Proskuryakov 2017-05-19 23:45:05 PDT
It's the better one to use in new tests. If some functions were only added to -pre, they should be added to js-test.js too.