Bug 172368 – [GTK] Fix developer mode builds from release tarballs

• Status: NEW
• Component: WebKitGTK

[Emanuele Aina]

The Tools/TestRunnerShared folder was missing from the tarball generated by `make distcheck`, breaking builds using `-DDEVELOPER_MODE=ON`.

[Emanuele Aina]

Created attachment 310674 [details]
Patch

[Carlos Garcia Campos]

Comment on attachment 310674 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=310674&action=review

> Tools/gtk/make-dist.py:247
> -        command = ['cmake', '-DPORT=%s' % port, '-DCMAKE_INSTALL_PREFIX=%s' % install_dir, '-DCMAKE_BUILD_TYPE=Release', dist_dir]
> +        command = ['cmake', '-DPORT=%s' % port, '-DCMAKE_INSTALL_PREFIX=%s' % install_dir, '-DCMAKE_BUILD_TYPE=Release', '-DDEVELOPER_MODE=ON', dist_dir]

The point of make distcheck is precisely to make a production build, ensuring it builds without the developer mode.

> Tools/gtk/manifest.txt.in:88
> +directory Tools/TestRunnerShared

I don't know why we are including WTR in the tarball, because I don't think it's possible to run layout tests from a tarball anyway, since we are not including all the webkitpy and tools required. I think the right fix for this is to remove ImageDiff, WTR and DRT from the tarball. Only unit tests should be included, I think.

[Carlos Garcia Campos]

While distcheck should always run a production build, I agree it should be possible to build a tarball with developer mode enabled. Layout tests will not be available, but api tests and other developer mode feature will, so we should fix it. We might add an option to the make-dist.py script to enable developer mode (disabled by default).