Bug 172366 - Rename ENABLE_APPLE_PAY_DELEGATE to ENABLE_APPLE_PAY_SESSION_V3 and bump the supported version number
Summary: Rename ENABLE_APPLE_PAY_DELEGATE to ENABLE_APPLE_PAY_SESSION_V3 and bump the ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andy Estes
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-05-19 10:27 PDT by Andy Estes
Modified: 2017-05-31 14:35 PDT (History)
14 users (show)

See Also:

Attachments
Patch (59.96 KB, patch)
2017-05-19 10:31 PDT, Andy Estes 		no flags Details | Formatted Diff | Diff
Patch (22.63 KB, patch)
2017-05-31 13:56 PDT, Andy Estes 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andy Estes 2017-05-19 10:27:13 PDT 
Rename ENABLE_APPLE_PAY_DELEGATE to ENABLE_APPLE_PAY_SESSION_V3 and bump the supported version number
Comment 1 Andy Estes 2017-05-19 10:31:57 PDT 
Created attachment 310672 [details]
Patch
Comment 2 WebKit Commit Bot 2017-05-26 09:04:15 PDT 
Comment on attachment 310672 [details]
Patch

Rejecting attachment 310672 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-03', 'apply-attachment', '--no-update', '--non-interactive', 310672, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Last 500 characters of output:
ng file Source/WebKit2/WebProcess/ApplePay/WebPaymentCoordinator.cpp
patching file Tools/ChangeLog
Hunk #1 succeeded at 1 with fuzz 3.
patching file Tools/TestWebKitAPI/Configurations/FeatureDefines.xcconfig
Hunk #2 FAILED at 254.
1 out of 2 hunks FAILED -- saving rejects to file Tools/TestWebKitAPI/Configurations/FeatureDefines.xcconfig.rej

Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Daniel Bates']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Full output: http://webkit-queues.webkit.org/results/3822362
Comment 3 Andy Estes 2017-05-31 13:56:49 PDT 
Created attachment 311629 [details]
Patch
Comment 4 WebKit Commit Bot 2017-05-31 14:35:34 PDT 
Comment on attachment 311629 [details]
Patch

Clearing flags on attachment: 311629

Committed r217626: <http://trac.webkit.org/changeset/217626>
Comment 5 WebKit Commit Bot 2017-05-31 14:35:36 PDT 
All reviewed patches have been landed.  Closing bug.